[CustomerCenter] Adds SubscriptionDetailsView#1863
Conversation
| import androidx.compose.ui.unit.dp | ||
|
|
||
| /** | ||
| * Exported from [Compose Icons](https://composeicons.com/icons/material-symbols/outlined/calendar_month). |
There was a problem hiding this comment.
I decided against including the androidx.compose.material:material-icons-extended library, as that one is really large and we're not minifying it properly. Let me know what you think.
There was a problem hiding this comment.
Hmm I think we would be minifying it? As in, we are only not minifying our SDKs, but not our dependencies I believe... But yeah, if we only need these images, it might be ok to just have them here.
There was a problem hiding this comment.
Ah you're right! No strong opinion on this. I guess a tiny advantage of not including the library is that we don't increase the size of developers' debug builds.
There was a problem hiding this comment.
Yeah let's do this for now and we can always revisit later if needed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1863 +/- ##
=======================================
Coverage 82.83% 82.83%
=======================================
Files 222 222
Lines 7703 7703
Branches 1084 1084
=======================================
Hits 6381 6381
Misses 899 899
Partials 423 423
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tonidero
left a comment
There was a problem hiding this comment.
Makes sense to me! As you said, we can iterate on that later if needed.
| import androidx.compose.ui.unit.dp | ||
|
|
||
| /** | ||
| * Exported from [Compose Icons](https://composeicons.com/icons/material-symbols/outlined/calendar_month). |
There was a problem hiding this comment.
Hmm I think we would be minifying it? As in, we are only not minifying our SDKs, but not our dependencies I believe... But yeah, if we only need these images, it might be ok to just have them here.
📸 Snapshot Test2 added, 69 unchanged
🛸 Powered by Emerge Tools |
**This is an automatic release.** ## RevenueCat SDK ### 🐞 Bugfixes * Save SDK configuration on paywall activity so it can reconfigure automatically (#1872) via Toni Rico (@tonidero) ### 📦 Dependency Updates * Bump fastlane from 2.223.1 to 2.224.0 (#1870) via dependabot[bot] (@dependabot[bot]) * Bump fastlane-plugin-revenuecat_internal from `5b2e35c` to `3b1e7cf` (#1865) via dependabot[bot] (@dependabot[bot]) * Bump fastlane from 2.222.0 to 2.223.1 (#1860) via dependabot[bot] (@dependabot[bot]) * Bump fastlane-plugin-revenuecat_internal from `55a0455` to `5b2e35c` (#1858) via dependabot[bot] (@dependabot[bot]) ### 🔄 Other Changes * [CustomerCenter] Fix help path deserializing when unknown type (#1869) via Toni Rico (@tonidero) * [CustomerCenter] Create `CustomerCenter` composable and view model with some initial UI (#1867) via Toni Rico (@tonidero) * [CustomerCenter] Add networking layer and models (#1859) via Toni Rico (@tonidero) * [CustomerCenter] Adds SubscriptionDetailsView (#1863) via JayShortway (@JayShortway) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
In this PR
SubscriptionDetailsView☝️, modelled after the iOS namesake. (The black border is Android Studio's preview UI.)TopLevelPropertyNamingDetekt rule to allow CamelCase constants, following the Compose guidelines. I modified Detekt's recommendation to also allow SCREAMING_SNAKE_CASE, as we use that in other parts.Not in this PR
SubscriptionDetailsView.I was thinking we can update the design as we go, when we have a better idea of what this is going to look like, but let me know what you think!