Fix offering metadata not fulling expanding#1199
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1199 +/- ##
=======================================
Coverage 85.92% 85.92%
=======================================
Files 181 181
Lines 6217 6217
Branches 900 900
=======================================
Hits 5342 5342
Misses 533 533
Partials 342 342
|
tonidero
approved these changes
Aug 16, 2023
Contributor
|
Reminder to avoid putting internal ticket names in commit titles, those aren't useful in a public repo since nobody else can see them. Having |
Member
Author
|
OOOPS... sorry! Too much time in backend 🤦♂️ @NachoSoto Can I add a Danger rule in for that? 👀 |
Contributor
|
@joshdholtz actually that sounds like a great idea! |
tonidero
pushed a commit
that referenced
this pull request
Aug 17, 2023
**This is an automatic release.** ### Bugfixes * Fix offering metadata not fulling expanding (#1199) via Josh Holtz (@joshdholtz) ### Other Changes * Fix deploying extra packages (#1200) via Toni Rico (@tonidero) * Debug view: Support deploying both noop and debug version of `debugview` package (#1192) via Toni Rico (@tonidero) --------- Co-authored-by: revenuecat-ops <ops@revenuecat.com> Co-authored-by: Josh Holtz <me@joshholtz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes DENG-494
Metadata not fully expanding on native Android and hybrids.
Description
.toMap(deep=true)withinJSONObject.toMap()to keep expanding nested objects.toMap(deep=true)withinJSONArray.toList()to keep expanding nested objectsJSONObject,JSONArray, and offering