Debug view: Support deploying both noop and debug version of debugview package#1192
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1192 +/- ##
=======================================
Coverage 85.92% 85.92%
=======================================
Files 181 181
Lines 6217 6217
Branches 900 900
=======================================
Hits 5342 5342
Misses 533 533
Partials 342 342 ☔ View full report in Codecov by Sentry. |
tonidero
commented
Aug 7, 2023
Contributor
Author
There was a problem hiding this comment.
Users will be using the library like this:
debugImplementation "com.revenuecat.purchase:purchases-debugview:6.10.0"
releaseImplementation "com.revenuecat.purchase:purchases-debugview-noop:6.10.0"
Contributor
Author
There was a problem hiding this comment.
Yup, once we deploy the first version, planning to add instructions on how to use this there 👍
9a4a629 to
159b020
Compare
tonidero
commented
Aug 9, 2023
| includeBuild("../../") { | ||
| dependencySubstitution { | ||
| substitute module("com.revenuecat.purchases:debugview") using project(":debugview") | ||
| substitute module("com.revenuecat.purchases:debugview") using project(":ui:debugview") |
Contributor
Author
There was a problem hiding this comment.
This is to fix magic weather compose after #1191
aboedo
approved these changes
Aug 14, 2023
tonidero
added a commit
that referenced
this pull request
Aug 16, 2023
### Description This broke in #1192. We were missing some fixes for the refactor to deploy the debug view
tonidero
pushed a commit
that referenced
this pull request
Aug 17, 2023
**This is an automatic release.** ### Bugfixes * Fix offering metadata not fulling expanding (#1199) via Josh Holtz (@joshdholtz) ### Other Changes * Fix deploying extra packages (#1200) via Toni Rico (@tonidero) * Debug view: Support deploying both noop and debug version of `debugview` package (#1192) via Toni Rico (@tonidero) --------- Co-authored-by: revenuecat-ops <ops@revenuecat.com> Co-authored-by: Josh Holtz <me@joshholtz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This sets up the project to be able to deploy the
defaultsReleasevariant aspurchases-debug-view-nooppackage anddefaultsDebugvariant aspurchases-debug-viewHold until #1187 and #1191 are merged.