Remove common module#1106
Merged
Merged
Conversation
0e20d03 to
36fea5a
Compare
Codecov Report
@@ Coverage Diff @@
## main #1106 +/- ##
==========================================
- Coverage 85.16% 84.81% -0.35%
==========================================
Files 186 180 -6
Lines 6551 6164 -387
Branches 929 915 -14
==========================================
- Hits 5579 5228 -351
+ Misses 601 573 -28
+ Partials 371 363 -8
|
Base automatically changed from
cesar/sdk-3211-move-featureamazon-files-into-common-module
to
main
June 30, 2023 07:38
eed6873 to
085ae00
Compare
085ae00 to
d3dae47
Compare
vegaro
commented
Jun 30, 2023
| import kotlin.time.Duration | ||
|
|
||
| class HTTPClient( | ||
| internal class HTTPClient( |
Member
Author
There was a problem hiding this comment.
making these internal is breaking the compilation because AmazonBackend is public and it exposes these (which are internal). Not sure if it's better to break semver and make AmazonBackend internal or expose these. cc: @tonidero
Contributor
There was a problem hiding this comment.
Huh... I would have expected that since AmazonBackend which is public in the feature/amazon module, has an internal class in the constructor BackendHelper (note that the amazon module is not exposing the common module), Kotlin should have given an error, that would force us to make the constructor of that class internal at least...
Not sure why that's not the case... currently, if I try to create an AmazonBackend in the API tests, I can't really do it...
So I guess they would be able to create one if someone also included the common module. And since we are making these internal, that would indeed be a breaking change... However, honestly, no-one should be creating these classes directly, so I'm kinda leaning towards making them internal
vegaro
commented
Jun 30, 2023
vegaro
commented
Jun 30, 2023
|
|
||
| include ':feature:amazon' | ||
| include ':integration-tests' | ||
| include ':test-utils' |
Member
Author
There was a problem hiding this comment.
It was easier to remove the test-utils now in this PR and merge it in purchases so I removed it
tonidero
reviewed
Jul 5, 2023
tonidero
left a comment
Contributor
There was a problem hiding this comment.
Looks great! left a few questions
tonidero
approved these changes
Jul 5, 2023
tonidero
left a comment
Contributor
There was a problem hiding this comment.
Nice job! Almost there!
tonidero
added a commit
that referenced
this pull request
Jul 6, 2023
### Description This fixes a couple of things: - Fixes integration tests after the changes in #1106. There were some compiler issues - Changes the project used by production integration tests and production backend integration tests to make it more stable (We were using a shared project before 😬 )
tonidero
added a commit
that referenced
this pull request
Jul 10, 2023
### Description We forgot to update the paths to update versions in #1106. This fixes it so we can make a new release
tonidero
added a commit
that referenced
this pull request
Jul 12, 2023
**This is an automatic release.** ### New Features * `Trusted Entitlements`: made API stable (#1105) via NachoSoto (@NachoSoto) This new feature prevents MitM attacks between the SDK and the RevenueCat server. With verification enabled, the SDK ensures that the response created by the server was not modified by a third-party, and the entitlements received are exactly what was sent. This is 100% opt-in. `EntitlementInfos` have a new `VerificationResult` property, which will indicate the validity of the responses when this feature is enabled. ```kotlin fun configureRevenueCat() { val configuration = PurchasesConfiguration.Builder(context, apiKey) .entitlementVerificationMode(EntitlementVerificationMode.INFORMATIONAL) .build() Purchases.configure(configuration) } ``` ### Experimental features * Add await offerings (#1096) via Cesar de la Vega (@vegaro) ### Bugfixes * Fix issue updating customer info on app open (#1128) via Toni Rico (@tonidero) ### Dependency Updates * Bump fastlane-plugin-revenuecat_internal from `13773d2` to `b2108fb` (#1095) via dependabot[bot] (@dependabot[bot]) ### Other Changes * [PurchaseTester] Add option to purchase an arbitrary product id (#1099) via Mark Villacampa (@MarkVillacampa) * Fix release path after module refactor (#1129) via Toni Rico (@tonidero) * Fix load shedder integration tests (#1125) via Toni Rico (@tonidero) * Trusted entitlements: New trusted entitlements signature format (#1117) via Toni Rico (@tonidero) * Fix integration tests and change to a different project (#1123) via Toni Rico (@tonidero) * Move files into src/main/kotlin (#1122) via Cesar de la Vega (@vegaro) * Remove public module (#1113) via Cesar de la Vega (@vegaro) * Remove common module (#1106) via Cesar de la Vega (@vegaro) * Fix flaky integration tests: Wait for coroutines to finish before continuing (#1120) via Toni Rico (@tonidero) * Move amazon module into purchases (#1112) via Cesar de la Vega (@vegaro) * Trusted entitlements: Add IntermediateSignatureHelper to handle intermediate signature verification process (#1110) via Toni Rico (@tonidero) * Trusted entitlements: Add Signature type to process new signature response format (#1109) via Toni Rico (@tonidero) * [EXTERNAL] Add `awaitCustomerInfo` / coroutines tests to `TrustedEntitlementsInformationalModeIntegrationTest` (#1077) via @pablo-guardiola (#1107) via Toni Rico (@tonidero) * Remove feature:google module (#1104) via Cesar de la Vega (@vegaro) * Remove identity module (#1103) via Cesar de la Vega (@vegaro) * Remove subscriber attributes module (#1102) via Cesar de la Vega (@vegaro) * Delete utils module (#1098) via Cesar de la Vega (@vegaro) * Remove strings module (#1097) via Cesar de la Vega (@vegaro) * Update CHANGELOG.md to include external contribution (#1100) via Cesar de la Vega (@vegaro) * [EXTERNAL] Add missing `fetchPolicy` parameter to `awaitCustomerInfo` API (#1086) via @pablo-guardiola (#1090) via Toni Rico (@tonidero) --------- Co-authored-by: revenuecat-ops <ops@revenuecat.com> Co-authored-by: Toni Rico <antonio.rico.diez@revenuecat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
