[EXTERNAL] Add missing fetchPolicy parameter to awaitCustomerInfo API#1086
Merged
Conversation
60054a6 to
b831d2b
Compare
pablo-guardiola
commented
Jun 22, 2023
Contributor
Author
There was a problem hiding this comment.
Did we agree on leaving the door open to Java users? #1012 (comment)
Not sure if we'd like to mark this with @JvmSynthetic as we did for https://github.com/RevenueCat/purchases-android/pull/1066/files#r1229531480
If so, let me know and I'll replace @JvmOverloads by @JvmSynthetic.
Contributor
There was a problem hiding this comment.
I think this API doesn't need to be available in Java, so I would maybe mark it with @JvmSynthetic. Thoughts @vegaro?
2 tasks
b831d2b to
1707cc4
Compare
tonidero
reviewed
Jun 23, 2023
tonidero
left a comment
Contributor
There was a problem hiding this comment.
Just a comment to add an API test, other than that, looks great!
Contributor
There was a problem hiding this comment.
I think this API doesn't need to be available in Java, so I would maybe mark it with @JvmSynthetic. Thoughts @vegaro?
Contributor
There was a problem hiding this comment.
Could you add the usage of this in the api-tests module? It's been helpful to avoid regressions in the public API.
1707cc4 to
5968599
Compare
Contributor
Author
|
@tonidero addressed the feedback. This is ready for another round of 👀 |
tonidero
approved these changes
Jun 26, 2023
tonidero
left a comment
Contributor
There was a problem hiding this comment.
This looks good! I will get this merged in. Thanks for adding that!
fetchPolicy parameter to awaitCustomerInfo APIfetchPolicy parameter to awaitCustomerInfo API
tonidero
pushed a commit
that referenced
this pull request
Jun 26, 2023
… API (#1086) <!-- Thank you for contributing to Purchases! Before pressing the "Create Pull Request" button, please provide the following: --> ### Checklist - [ ] If applicable, unit tests - [ ] If applicable, create follow-up issues for `purchases-ios` and hybrids ### Motivation **Why is this change required? What problem does it solve?** Follow up from #1077 (comment) <!-- Please link to issues following this format: Resolves #999999 --> ### Description **Describe your changes in detail** - Add missing `fetchPolicy` parameter to `awaitCustomerInfo` API **Please describe in detail how you tested your changes** - Run `purchases` tests - Run `examples.purchase-test` app cc @vegaro @tonidero
tonidero
added a commit
that referenced
this pull request
Jun 26, 2023
… API (#1086) (#1090) <!-- Thank you for contributing to Purchases! Before pressing the "Create Pull Request" button, please provide the following: --> ### Checklist - [ ] If applicable, unit tests - [ ] If applicable, create follow-up issues for `purchases-ios` and hybrids ### Motivation **Why is this change required? What problem does it solve?** Follow up from #1077 (comment) <!-- Please link to issues following this format: Resolves #999999 --> ### Description **Describe your changes in detail** - Add missing `fetchPolicy` parameter to `awaitCustomerInfo` API **Please describe in detail how you tested your changes** - Run `purchases` tests - Run `examples.purchase-test` app Contributed by @pablo-guardiola Co-authored-by: pablo-guardiola <131195486+pablo-guardiola@users.noreply.github.com>
This was referenced Jun 27, 2023
tonidero
added a commit
that referenced
this pull request
Jul 12, 2023
**This is an automatic release.** ### New Features * `Trusted Entitlements`: made API stable (#1105) via NachoSoto (@NachoSoto) This new feature prevents MitM attacks between the SDK and the RevenueCat server. With verification enabled, the SDK ensures that the response created by the server was not modified by a third-party, and the entitlements received are exactly what was sent. This is 100% opt-in. `EntitlementInfos` have a new `VerificationResult` property, which will indicate the validity of the responses when this feature is enabled. ```kotlin fun configureRevenueCat() { val configuration = PurchasesConfiguration.Builder(context, apiKey) .entitlementVerificationMode(EntitlementVerificationMode.INFORMATIONAL) .build() Purchases.configure(configuration) } ``` ### Experimental features * Add await offerings (#1096) via Cesar de la Vega (@vegaro) ### Bugfixes * Fix issue updating customer info on app open (#1128) via Toni Rico (@tonidero) ### Dependency Updates * Bump fastlane-plugin-revenuecat_internal from `13773d2` to `b2108fb` (#1095) via dependabot[bot] (@dependabot[bot]) ### Other Changes * [PurchaseTester] Add option to purchase an arbitrary product id (#1099) via Mark Villacampa (@MarkVillacampa) * Fix release path after module refactor (#1129) via Toni Rico (@tonidero) * Fix load shedder integration tests (#1125) via Toni Rico (@tonidero) * Trusted entitlements: New trusted entitlements signature format (#1117) via Toni Rico (@tonidero) * Fix integration tests and change to a different project (#1123) via Toni Rico (@tonidero) * Move files into src/main/kotlin (#1122) via Cesar de la Vega (@vegaro) * Remove public module (#1113) via Cesar de la Vega (@vegaro) * Remove common module (#1106) via Cesar de la Vega (@vegaro) * Fix flaky integration tests: Wait for coroutines to finish before continuing (#1120) via Toni Rico (@tonidero) * Move amazon module into purchases (#1112) via Cesar de la Vega (@vegaro) * Trusted entitlements: Add IntermediateSignatureHelper to handle intermediate signature verification process (#1110) via Toni Rico (@tonidero) * Trusted entitlements: Add Signature type to process new signature response format (#1109) via Toni Rico (@tonidero) * [EXTERNAL] Add `awaitCustomerInfo` / coroutines tests to `TrustedEntitlementsInformationalModeIntegrationTest` (#1077) via @pablo-guardiola (#1107) via Toni Rico (@tonidero) * Remove feature:google module (#1104) via Cesar de la Vega (@vegaro) * Remove identity module (#1103) via Cesar de la Vega (@vegaro) * Remove subscriber attributes module (#1102) via Cesar de la Vega (@vegaro) * Delete utils module (#1098) via Cesar de la Vega (@vegaro) * Remove strings module (#1097) via Cesar de la Vega (@vegaro) * Update CHANGELOG.md to include external contribution (#1100) via Cesar de la Vega (@vegaro) * [EXTERNAL] Add missing `fetchPolicy` parameter to `awaitCustomerInfo` API (#1086) via @pablo-guardiola (#1090) via Toni Rico (@tonidero) --------- Co-authored-by: revenuecat-ops <ops@revenuecat.com> Co-authored-by: Toni Rico <antonio.rico.diez@revenuecat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
purchases-iosand hybridsMotivation
Why is this change required? What problem does it solve?
Follow up from #1077 (comment)
Description
Describe your changes in detail
fetchPolicyparameter toawaitCustomerInfoAPIPlease describe in detail how you tested your changes
purchasestestsexamples.purchase-testappcc @vegaro @tonidero