Skip to content

Conversation

@filipecosta90
Copy link
Collaborator

As discussed with @gkorland, we will only enable the benchmark triggers on integration benchmarks.

@filipecosta90 filipecosta90 added the x:quality Code-Quality related (performance, test, etc. -not directly affecting functionality) label Nov 9, 2021
@filipecosta90 filipecosta90 force-pushed the perf.only.on.integration branch from ff91924 to 455aff5 Compare November 9, 2021 14:16
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #2026 (455aff5) into master (db53ac0) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2026   +/-   ##
=======================================
  Coverage   92.77%   92.78%           
=======================================
  Files         247      247           
  Lines       21649    21649           
=======================================
+ Hits        20085    20087    +2     
+ Misses       1564     1562    -2     
Impacted Files Coverage Δ
src/util/thpool/thpool.c 82.38% <0.00%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 031f5ea...455aff5. Read the comment docs.

@AviAvni AviAvni merged commit cf94045 into master Nov 10, 2021
@AviAvni AviAvni deleted the perf.only.on.integration branch November 10, 2021 11:54
swilly22 added a commit that referenced this pull request Nov 16, 2021
* WIP

* WIP

* Add flow test

* Reintroduce OpUpdate

* Pass test suite

* Fix memory leak

* Update serialization routines

* Address PR comments

* Use macro for retrieving labels

* Address PR comments

* use mkdocs-modules-template (#1586)

* Fix idx assertion (#1580)

* Fix flawed assertion in index deletion logic

* Reduce KPI for updates_baseline benchmark

* Address PR comments

* Address PR comments

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>

* Always report run-time errors as the sole reply (#1590)

* Always report run-time errors as the sole reply

* Update test_timeout.py

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>

* remove wrong assertion (#1591)

* Address PR comments

* Fix label matrix resizing

* Increment encoding version

* query graph node refactoring

* sync node_labels to (node_cap X lbl_count) dim

* avoid unnecessary lock

* a bit of tests refactoring

* re-enable unit tests

* Post-merge fixes

* Add support for multiple labels in bulk loader

* Post-merge fixes

* fix build

* fix submodule issue

* fix _Graph_LabelNode

* fix matrix resize

* fix build

* make test readable

* review

* fix apply all pending

* build node_labels matrix from label matrices

* move iter to stack

* update RediSearch

* implement index specific fields

* add tests

* fix build

* address review

* refactor

* refactor

* clean

* add tests

* add language and stopword output to db.indexes

* update test

* add documentation

* save index schema in rdb

* add test

* Resize label mapping matrix when creating nodes

* update redisearch

* use new api

* Flush all matrices on RDB load

* update redisearch

* use new api

* review changes [WIP]

* review changes [WIP]

* update RediSearch

* review changes [WIP]

* review changes [WIP]

* More extensive testing for multi-label support

* review changes [WIP]

* optimize starting point doc

* Track node count per label in graph statistics

* Address PR comments

* optimize label scan WIP

* optimize label scan WIP

* test multi-label label scan optimization

* Post-merge fixes

* Use new param style when invoking redisgraph-py from tests (#1953)

(cherry picked from commit 79c2edf)

* adding optimize_label_scan.c

* switch to graph statistics

* return zero matrix on no,unknown label

* Use indexed label with lowest NNZ in multi-label case

* WIP

* Fix AlgebraicExpression rewrite logic for multi-label

* Fix memory leaks

* simplifications

* Add documentation

* Additional multi-label bulk insert tests

* simplify algebraic expression src, dest operand locating

* update encoder to v10

* fix tests

* fix memory issue

* free stopwords

* free each stopword

* fix encoder

* fix memory leak

* Update commands.md

* stopwods only for full text index

* fix memory leak

* add tck test

* Update commands.md

Redundant double quotes removed.

* address review

* fix Env usage (#1998)

* Edge indexing (#1972)

* rename index_scan to node_by_index_scan

* getter apis for node, edge and schema

* introduce edge by index scan op

* specify index schema type when creating or deleting an index

* index specifies entity type

* index node, edge seperation

* index created edges

* update index upon edge deletion

* edge by index scan WIP

* WIP

* extend utilize indices to use edge indices

* add filter by source node

* introduce implicit index fields

* update edge index

* fix merge op

* fix for edge without alias

* fix merge

* use Schema_GetID

* add edge to record after update src and dest nodes

* fix edge index decoder

* db.indexes list ege indexes

* handle src and dst aware

* fix src dest aware implementation

* add review

* Add parser support for CREATE INDEX FOR syntax

* handle new index syntax

* fix prop name extract

* test index creation

* filter dest node and add tests

* add entity type to db.indexes

* update id before cloning the filter

* initialize yield_entity_type

* add documentation

* fix memory issue

* fix children aware and add tests

* check for child record

* add update index tests

* address review

* address review

* fix comment

* fix filter other node

* addres review

* utilize index has labels with multi label

* no need to change v9 decode

* add delete index tests

* fix comment

* address review

* space

* clean tests

* fix comment

Co-authored-by: swilly22 <roi@redislabs.com>
Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com>

* Update References.md (#1997)

SlideShare link fixed

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>

* fix crash in utilize index using wrong query_graph (#2002)

* platform suffix on arm (#2003)

* platform suffix for arm

* readies latest for graph arm tag fix

* tying docs builds to 3.9 until mkdocs is upgraded (#2001)

* GraphBLAS 5.1.9 (#2007)

* disable GraphBLAS mempool if OpenMP is missing

* GraphBLAS V5.1.8

* add static_only rule

* remove unsused types and operations

* GraphBLAS V5.1.8 tests pass

* GraphBLAS V5.1.9

* remove memory-pool openmp disable

* GraphBLAS V5.1.10 (#2010)

Co-authored-by: swilly22 <roi@redislabs.com>

* update label for every node in ast (#2014)

* update label for every node in ast

* add comment for the test

* Update test_multi_label.py

* address review

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>

* commands.json (#1964)

Co-authored-by: Guy Korland <gkorland@gmail.com>

* Update README.md

* Update README.md

* Running only performance CI on integration branches (#2026)

* update redisearch to 2.0.13 (#2032)

Co-authored-by: swilly22 <roi@redislabs.com>
Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com>
Co-authored-by: Leibale Eidelman <leibale1998@gmail.com>
Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
Co-authored-by: min.wu <50101159+whitewum@users.noreply.github.com>
Co-authored-by: Lior Kogan <koganlior1@gmail.com>
Co-authored-by: Chayim <chayim@users.noreply.github.com>
Co-authored-by: Guy Korland <gkorland@gmail.com>
Co-authored-by: filipe oliveira <filipecosta.90@gmail.com>
jeffreylovitz pushed a commit that referenced this pull request Dec 7, 2021
pnxguide pushed a commit to CMU-SPEED/RedisGraph that referenced this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog x:quality Code-Quality related (performance, test, etc. -not directly affecting functionality)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants