-
Notifications
You must be signed in to change notification settings - Fork 233
Update 2.8 #2034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update 2.8 #2034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix flawed assertion in index deletion logic * Reduce KPI for updates_baseline benchmark * Address PR comments * Address PR comments Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
* Always report run-time errors as the sole reply * Update test_timeout.py Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
fix a typo
Redundant double quotes removed.
Update commands.md
…upport Multi label and redisearch support
* rename index_scan to node_by_index_scan * getter apis for node, edge and schema * introduce edge by index scan op * specify index schema type when creating or deleting an index * index specifies entity type * index node, edge seperation * index created edges * update index upon edge deletion * edge by index scan WIP * WIP * extend utilize indices to use edge indices * add filter by source node * introduce implicit index fields * update edge index * fix merge op * fix for edge without alias * fix merge * use Schema_GetID * add edge to record after update src and dest nodes * fix edge index decoder * db.indexes list ege indexes * handle src and dst aware * fix src dest aware implementation * add review * Add parser support for CREATE INDEX FOR syntax * handle new index syntax * fix prop name extract * test index creation * filter dest node and add tests * add entity type to db.indexes * update id before cloning the filter * initialize yield_entity_type * add documentation * fix memory issue * fix children aware and add tests * check for child record * add update index tests * address review * address review * fix comment * fix filter other node * addres review * utilize index has labels with multi label * no need to change v9 decode * add delete index tests * fix comment * address review * space * clean tests * fix comment Co-authored-by: swilly22 <roi@redislabs.com> Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com>
SlideShare link fixed Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
* platform suffix for arm * readies latest for graph arm tag fix
* disable GraphBLAS mempool if OpenMP is missing * GraphBLAS V5.1.8 * add static_only rule * remove unsused types and operations * GraphBLAS V5.1.8 tests pass * GraphBLAS V5.1.9 * remove memory-pool openmp disable
Co-authored-by: swilly22 <roi@redislabs.com>
* update label for every node in ast * add comment for the test * Update test_multi_label.py * address review Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
Co-authored-by: Guy Korland <gkorland@gmail.com>
Codecov Report
@@ Coverage Diff @@
## 2.8 #2034 +/- ##
==========================================
+ Coverage 92.67% 92.78% +0.11%
==========================================
Files 239 247 +8
Lines 20512 21649 +1137
==========================================
+ Hits 19010 20088 +1078
- Misses 1502 1561 +59
Continue to review full report at Codecov.
|
swilly22
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.