Skip to content

Conversation

@AviAvni
Copy link
Contributor

@AviAvni AviAvni commented Nov 16, 2021

No description provided.

swilly22 and others added 30 commits January 29, 2021 17:55
* Fix flawed assertion in index deletion logic

* Reduce KPI for updates_baseline benchmark

* Address PR comments

* Address PR comments

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
* Always report run-time errors as the sole reply

* Update test_timeout.py

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
AviAvni and others added 26 commits October 13, 2021 14:32
Redundant double quotes removed.
…upport

Multi label and redisearch support
* rename index_scan to node_by_index_scan

* getter apis for node, edge and schema

* introduce edge by index scan op

* specify index schema type when creating or deleting an index

* index specifies entity type

* index node, edge seperation

* index created edges

* update index upon edge deletion

* edge by index scan WIP

* WIP

* extend utilize indices to use edge indices

* add filter by source node

* introduce implicit index fields

* update edge index

* fix merge op

* fix for edge without alias

* fix merge

* use Schema_GetID

* add edge to record after update src and dest nodes

* fix edge index decoder

* db.indexes list ege indexes

* handle src and dst aware

* fix src dest aware implementation

* add review

* Add parser support for CREATE INDEX FOR syntax

* handle new index syntax

* fix prop name extract

* test index creation

* filter dest node and add tests

* add entity type to db.indexes

* update id before cloning the filter

* initialize yield_entity_type

* add documentation

* fix memory issue

* fix children aware and add tests

* check for child record

* add update index tests

* address review

* address review

* fix comment

* fix filter other node

* addres review

* utilize index has labels with multi label

* no need to change v9 decode

* add delete index tests

* fix comment

* address review

* space

* clean tests

* fix comment

Co-authored-by: swilly22 <roi@redislabs.com>
Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com>
SlideShare link fixed

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
* platform suffix for arm

* readies latest for graph arm tag fix
* disable GraphBLAS mempool if OpenMP is missing

* GraphBLAS V5.1.8

* add static_only rule

* remove unsused types and operations

* GraphBLAS V5.1.8 tests pass

* GraphBLAS V5.1.9

* remove memory-pool openmp disable
Co-authored-by: swilly22 <roi@redislabs.com>
* update label for every node in ast

* add comment for the test

* Update test_multi_label.py

* address review

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
Co-authored-by: Guy Korland <gkorland@gmail.com>
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #2034 (f565209) into 2.8 (f8b40e5) will increase coverage by 0.11%.
The diff coverage is 96.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.8    #2034      +/-   ##
==========================================
+ Coverage   92.67%   92.78%   +0.11%     
==========================================
  Files         239      247       +8     
  Lines       20512    21649    +1137     
==========================================
+ Hits        19010    20088    +1078     
- Misses       1502     1561      +59     
Impacted Files Coverage Δ
src/ast/cypher_whitelist.c 87.50% <ø> (ø)
src/execution_plan/optimizations/seek_by_id.c 100.00% <ø> (ø)
src/graph/entities/graph_entity.c 48.46% <0.00%> (-1.54%) ⬇️
src/graph/entities/node.c 0.00% <0.00%> (ø)
src/graph/rg_matrix/rg_remove_element.c 98.64% <ø> (-0.04%) ⬇️
src/graph/rg_matrix/rg_remove_entry.c 100.00% <ø> (ø)
src/graph/rg_matrix/rg_set_element_bool.c 100.00% <ø> (ø)
src/graph/rg_matrix/rg_set_element_uint64.c 97.87% <ø> (-0.05%) ⬇️
src/resultset/formatters/resultset_replyverbose.c 15.65% <22.22%> (ø)
src/execution_plan/ops/op_update.c 89.04% <80.00%> (-1.73%) ⬇️
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8b40e5...f565209. Read the comment docs.

@swilly22 swilly22 merged commit dcf187f into 2.8 Nov 16, 2021
@swilly22 swilly22 deleted the update-2.8 branch November 16, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants