Skip to content

[MOD-9403] Remove stale varint target#6372

Merged
LukeMathWalker merged 1 commit intomasterfrom
remove-varint-static-lib
Jun 25, 2025
Merged

[MOD-9403] Remove stale varint target#6372
LukeMathWalker merged 1 commit intomasterfrom
remove-varint-static-lib

Conversation

@LukeMathWalker
Copy link
Copy Markdown
Collaborator

Describe the changes in the pull request

A leftover from #6308.

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

@LukeMathWalker LukeMathWalker enabled auto-merge June 25, 2025 08:23
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.69%. Comparing base (3d1ceb8) to head (edb822f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6372      +/-   ##
==========================================
- Coverage   88.75%   88.69%   -0.06%     
==========================================
  Files         251      251              
  Lines       41729    41729              
  Branches     3748     3748              
==========================================
- Hits        37036    37012      -24     
- Misses       4644     4668      +24     
  Partials       49       49              
Flag Coverage Δ
flow 81.34% <ø> (-0.18%) ⬇️
unit 46.72% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LukeMathWalker LukeMathWalker added this pull request to the merge queue Jun 25, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jun 25, 2025
Merged via the queue into master with commit f3aefd2 Jun 25, 2025
15 checks passed
@LukeMathWalker LukeMathWalker deleted the remove-varint-static-lib branch June 25, 2025 13:06
GuyAv46 added a commit that referenced this pull request Jul 20, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jul 22, 2025
* Revert "[MOD-10235] Polish varint implementation (#6346)"

This reverts commit a08d223.

* change runner

* Revert "[MOD-9403] Remove stale varint target (#6372)"

This reverts commit f3aefd2.

* Revert "MOD-9403: Replace varint.* with the Rust implementation (#6308)"

This reverts commit 428d202.
@LukeMathWalker LukeMathWalker restored the remove-varint-static-lib branch February 6, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants