Skip to content

Revert Rust Varint implementation on 8.2 - [MOD-10480]#6505

Merged
GuyAv46 merged 4 commits into8.2from
guyav-revert_rust_varint
Jul 22, 2025
Merged

Revert Rust Varint implementation on 8.2 - [MOD-10480]#6505
GuyAv46 merged 4 commits into8.2from
guyav-revert_rust_varint

Conversation

@GuyAv46
Copy link
Copy Markdown
Collaborator

@GuyAv46 GuyAv46 commented Jul 20, 2025 •
edited
Loading

Describe the changes in the pull request

Reverting Rust Varint refactor from 8.2 to avoid potential regression due to the partial refactor, and since the next step will not be part of 8.2.
We can see the regression has been resolved here

Reverting

  1. [MOD-10235] Polish varint implementation #6346
  2. [MOD-9403] Remove stale varint target #6372
  3. MOD-9403: Replace varint.* with the Rust implementation #6308 - The actual faulty PR

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

@GuyAv46 GuyAv46 marked this pull request as ready for review July 20, 2025 10:59
@GuyAv46 GuyAv46 enabled auto-merge July 20, 2025 10:59
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.54839% with 18 lines in your changes missing coverage. Please review.

Project coverage is 89.34%. Comparing base (ef5ec54) to head (8a6e05e).
Report is 2 commits behind head on 8.2.

Files with missing lines Patch % Lines
src/redisearch_rs/encode_decode/src/varint/mod.rs 95.08% 3 Missing and 6 partials ⚠️
src/varint.c 86.88% 8 Missing ⚠️
...earch_rs/encode_decode/src/varint/vector_writer.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              8.2    #6505      +/-   ##
==========================================
+ Coverage   89.30%   89.34%   +0.04%     
==========================================
  Files         251      250       -1     
  Lines       41353    41481     +128     
  Branches     3623     3666      +43     
==========================================
+ Hits        36931    37062     +131     
+ Misses       4378     4370       -8     
- Partials       44       49       +5
Flag Coverage Δ
flow 81.97% <89.47%> (-0.17%) ⬇️
unit 47.03% <92.47%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alonre24 alonre24 disabled auto-merge July 20, 2025 11:35
@GuyAv46 GuyAv46 requested a review from chesedo July 21, 2025 09:44
@GuyAv46 GuyAv46 added this pull request to the merge queue Jul 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 21, 2025
@GuyAv46 GuyAv46 added this pull request to the merge queue Jul 22, 2025
Merged via the queue into 8.2 with commit 4219601 Jul 22, 2025
40 of 42 checks passed
@GuyAv46 GuyAv46 deleted the guyav-revert_rust_varint branch July 22, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chesedo chesedo chesedo approved these changes

@alonre24 alonre24 alonre24 approved these changes

@LukeMathWalker LukeMathWalker Awaiting requested review from LukeMathWalker

Assignees

No one assigned

Labels

action:run-micro-benchmark size:XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GuyAv46 @chesedo @alonre24