Conversation
|
@Andre601 Is this pr ready for review? |
|
The Pull request of @Andre601 has been marked as Ready! It can now be reviewed and/or merged by Maintainers.
|
|
@abhijoshi2k Please review |
|
The changelog is handled in #41 :) |
|
@Andre601 @PuneetGopinath |
Ok |
Oh yes, you are right |
|
@Andre601 Can we add a Wiki to show supported placeholders in date format? Supported formats: https://www.npmjs.com/package/dateformat We support the |
You can get raw README of that package on this repo: https://github.com/felixge/node-dateformat |
Added an example |
It's available here : https://github.com/felixge/node-dateformat |
|
Not worth to add this info imo if it already exists. I already link to the npm package and that should be enough. You should better try to fix the conflicts in this PR because I won't touch JS stuff here. |
Okay. I'll resolve the conflicts. |
No, after resolving conflicts you should pull branch updation-time into update-readme. |
|
@abhijoshi2k Better delete node_modules folder. |
|
Better I itself will delete, because you started working and you are not going to see my comment |
The bot added it back |
Yeah, I see I will force push |
I think it's fine if we have node_modules. Only the cache files cause conflicts which can be ignored |
de16bf2 to
d0f0822
Compare
|
Why? GitHub docs itself says to remove it and and node_modules to .gitignore |
|
Idk why, but I don't see any conflicts on local. Should I merge this into |
|
Conflicts seem resolved. Just the action was failing for some reason, but I leave this up to you to figure out |
|
They fail because there is nothing to commit, or no changes happen to the files when you run |
* add date option * run build and format * add dateformat package * add dateformat package * run build and format * removed no changes detected * run build and format * removed timezone bug * run build and format * removed timezone bug * run build and format * Update index.js * run build and format * added logging statement * run build and format * Update index.js * run build and format * added multiline DATE_STRING support * run build and format * Update readme (#39) * Update README.md * Improve table * Add TIMEZONE_OFFSET to readme * Add DATE_STRING and {DATE} placeholder * Add DATE_FORMAT to readme * Improve descriptions * Update README.md Co-authored-by: Puneet Gopinath <baalkrshna@gmail.com> Co-authored-by: PuneetGopinath <76863199+PuneetGopinath@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * update package-lock.json * run prettier and build * run build and format Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: PuneetGopinath <76863199+PuneetGopinath@users.noreply.github.com> Co-authored-by: Andre_601 <11576465+Andre601@users.noreply.github.com> Co-authored-by: Puneet Gopinath <baalkrshna@gmail.com>

Thank you for contributing! Please check the following things before submiting your PR:
Required:
If necessary:
Description
Adds a section about the different Comment options you can use in markdown files.
Closes #
Note: we will close your PR without comment if you do not check the required boxes above and provide ALL requested information.