Add option to display date and time of last update by abhijoshi2k · Pull Request #40 · Readme-Workflows/recent-activity

abhijoshi2k · 2021-05-16T18:30:18Z

Thank you for contributing! Please check the following things before submiting your PR:

Required:

I have read and followed the contributing guidelines

If necessary:

I have updated the README and documentation.
I have updated the ChangeLog with the changes I have made.

Description

Added support for Date of update
Markdown file comments changed as follows:
 changes to 
 changes to 

For adding Date, add this to your markdown file:


For adding timezone and date format, add the following parameters to .yml file:
TIMEZONE_OFFSET

    description: "Timezone in which time is to be displayed"
    default: "0"
    required: false

DATE_STRING

    description: "String to be printed while printing updation date"
    default: "Last Updated: {DATE}"
    required: false

DATE_FORMAT

    description: "Format of how last updation time to be printed"
    default: "dddd, mmmm dS, yyyy, h:MM:ss TT"
    required: false

For date formats, refer : https://www.npmjs.com/package/dateformat

Closes #

Note: we will close your PR without comment if you do not check the required boxes above and provide ALL requested information.

…ecent-activity into updation-time

PuneetGopinath · 2021-05-17T09:06:57Z

It's just the offset from GMT which is UTC, so yes. I for example had +2:00 set on the above date

Thanks, do you think #39 is ready for review

Andre601 · 2021-05-17T09:10:14Z

Once this is merged will I add some info to the Release to inform about breaking changes.

abhijoshi2k · 2021-05-17T09:13:47Z

0 will set the timezone to UTC right

Yes

abhijoshi2k · 2021-05-17T09:14:51Z

@abhijoshi2k You have to review #39 before this pr can be merged

I shall do it. There are some changes I have to make here.
Will fix 1 bug and then review #39

…ivity into updation-time

* Update README.md * Improve table * Add TIMEZONE_OFFSET to readme * Add DATE_STRING and {DATE} placeholder * Add DATE_FORMAT to readme * Improve descriptions * Update README.md Co-authored-by: Puneet Gopinath <baalkrshna@gmail.com> Co-authored-by: PuneetGopinath <76863199+PuneetGopinath@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

PuneetGopinath · 2021-05-17T10:53:56Z

1 minute plz don't merge

abhijoshi2k · 2021-05-17T10:54:41Z

1 minute plz don't merge

I just pushed. 1 sec before your comment

PuneetGopinath · 2021-05-17T10:55:15Z

Ok

Andre601 · 2021-05-17T10:55:36Z

1 minute plz don't merge

Just add the Status: Ready label once your PR is ready for merge.

abhijoshi2k · 2021-05-17T10:57:19Z

1 minute plz don't merge

Just add the Status: Ready label once your PR is ready for merge.

It's ready.

github-actions · 2021-05-17T10:57:51Z

The Pull request of @abhijoshi2k has been marked as Ready!

It can now be reviewed and/or merged by Maintainers.

This is an automated response created by a GitHub Action
Mentioning the bot won't have any effect!

PuneetGopinath · 2021-05-17T10:58:00Z

The exact package-lock.json change was the thing I wanted to do by running npm install

abhijoshi2k · 2021-05-17T10:58:32Z

The exact package-lock.json change was the thing I wanted to do.

Okay. Now I think we can merge

PuneetGopinath · 2021-05-17T10:59:52Z

This time I by mistake forgot to squash and merge 🤣

abhijoshi2k · 2021-05-17T11:00:37Z

This time I by mistake forgot to squash and merge 🤣

It's fine...

abhijoshi2k and others added 5 commits May 16, 2021 18:23

working to add date

3c5b81e

add date

d2944c5

run build and format

f3501c2

add dateformat package

72211a4

add dateformat package

3ebbd55

github-actions bot added the Updates: documentation Improvements or additions to documentation label May 17, 2021

github-actions bot and others added 12 commits May 17, 2021 06:48

run build and format

8d7431c

removed no changes detected

48e845b

run build and format

d2e6569

removed timezone bug

f09239e

Merge branch 'updation-time' of https://github.com/Readme-Workflows/r…

518bf34

…ecent-activity into updation-time

run build and format

fa6ef67

removed timezone bug

b886bc3

Merge branch 'updation-time' of https://github.com/Readme-Workflows/r…

b7c429e

…ecent-activity into updation-time

run build and format

53a6555

Update index.js

cd9f14e

Merge branch 'updation-time' of https://github.com/Readme-Workflows/r…

f1b9083

…ecent-activity into updation-time

run build and format

421d13e

PuneetGopinath added minor Will be added to next minor release Status: In progress This pr or issue is in progress Type: enhancement New feature or request and removed Updates: documentation Improvements or additions to documentation labels May 17, 2021

added logging statement

ffc1151

github-actions bot added the Updates: documentation Improvements or additions to documentation label May 17, 2021

github-actions bot and others added 3 commits May 17, 2021 08:21

run build and format

a290d74

Update index.js

dcb2839

run build and format

cf67a9e

abhijoshi2k removed the Updates: documentation Improvements or additions to documentation label May 17, 2021

abhijoshi2k marked this pull request as ready for review May 17, 2021 08:51

abhijoshi2k requested a review from Andre601 as a code owner May 17, 2021 08:51

added multiline DATE_STRING support

430cebb

github-actions bot added the Updates: documentation Improvements or additions to documentation label May 17, 2021

run build and format

6fe4b98

abhijoshi2k removed the Updates: documentation Improvements or additions to documentation label May 17, 2021

Merge branch 'main' of https://github.com/Readme-Workflows/recent-act…

c5cf74d

…ivity into updation-time

github-actions bot added the Updates: documentation Improvements or additions to documentation label May 17, 2021

Andre601 added Type: breaking This change will break previous versions and removed Updates: documentation Improvements or additions to documentation labels May 17, 2021

Andre601 and others added 3 commits May 17, 2021 16:18

update package-lock.json

34df41c

run prettier and build

60eb6e2

run build and format

4661b3b

abhijoshi2k added Status: Ready The Pull request is ready for reviews and getting merged and removed Status: In progress This pr or issue is in progress labels May 17, 2021

PuneetGopinath merged commit 8ab0583 into main May 17, 2021

PuneetGopinath deleted the updation-time branch May 17, 2021 10:59

Conversation

abhijoshi2k commented May 16, 2021 • edited by PuneetGopinath Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

PuneetGopinath commented May 17, 2021

Uh oh!

Andre601 commented May 17, 2021

Uh oh!

abhijoshi2k commented May 17, 2021

Uh oh!

abhijoshi2k commented May 17, 2021

Uh oh!

PuneetGopinath commented May 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abhijoshi2k commented May 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PuneetGopinath commented May 17, 2021

Uh oh!

Andre601 commented May 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abhijoshi2k commented May 17, 2021

Uh oh!

github-actions bot commented May 17, 2021

Uh oh!

PuneetGopinath commented May 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abhijoshi2k commented May 17, 2021

Uh oh!

PuneetGopinath commented May 17, 2021

Uh oh!

abhijoshi2k commented May 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

abhijoshi2k commented May 16, 2021 •

edited by PuneetGopinath

Loading

PuneetGopinath commented May 17, 2021 •

edited

Loading

abhijoshi2k commented May 17, 2021 •

edited

Loading

Andre601 commented May 17, 2021 •

edited

Loading

PuneetGopinath commented May 17, 2021 •

edited

Loading