Skip to content

Restore GHA on Windows#6022

Merged
MichaelChirico merged 8 commits intomasterfrom
gha-windows
Apr 3, 2024
Merged

Restore GHA on Windows#6022
MichaelChirico merged 8 commits intomasterfrom
gha-windows

Conversation

@MichaelChirico
Copy link
Copy Markdown
Member

@MichaelChirico MichaelChirico commented Mar 24, 2024

Closes #5998

The first commit (c4283ee) left Appveyor intact to check comparative Windows CI timing of Appveyor vs. Windows, here's those timings:

i.e. roughly the same, therefore we should just drop Appveyor for simplicity.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.53%. Comparing base (9d73cf2) to head (2f4443c).

❗ Current head 2f4443c differs from pull request most recent head 873887d. Consider uploading reports for the commit 873887d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6022      +/-   ##
==========================================
- Coverage   97.53%   97.53%   -0.01%     
==========================================
  Files          80       80              
  Lines       14916    14913       -3     
==========================================
- Hits        14548    14545       -3     
  Misses        368      368              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelChirico MichaelChirico changed the base branch from master to test-exit March 25, 2024 04:09
Copy link
Copy Markdown
Member Author

MichaelChirico commented Mar 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MichaelChirico and the rest of your teammates on Graphite Graphite

@MichaelChirico MichaelChirico mentioned this pull request Mar 25, 2024
Base automatically changed from test-exit to master April 3, 2024 14:42
@MichaelChirico
Copy link
Copy Markdown
Member Author

Taking Jan's 👍 as GTG, given this doesn't touch any actual code.

@MichaelChirico MichaelChirico merged commit d35dceb into master Apr 3, 2024
@MichaelChirico MichaelChirico deleted the gha-windows branch April 3, 2024 15:56
@MichaelChirico
Copy link
Copy Markdown
Member Author

Appveyor was continuing to show up in PR checks, I thought it might be a PR-level cache (if Appveyor has already run on a PR, it will continue to attempt to do so), but then I started seeing it on fully fresh branches created after this was merged.

The first thing I found that was likely to work was: log in to Appveyor and revoke permissions for the app to this repo (originally granted by Arun some time ago). So if we decide to restore Appveyor, we'll have to re-grant those permissions to, as a note for posterity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run GHA on Windows, drop Appveyor test

1 participant