Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6022 +/- ##
==========================================
- Coverage 97.53% 97.53% -0.01%
==========================================
Files 80 80
Lines 14916 14913 -3
==========================================
- Hits 14548 14545 -3
Misses 368 368 ☔ View full report in Codecov by Sentry. |
a963fa4 to
fc36943
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MichaelChirico and the rest of your teammates on |
|
Taking Jan's 👍 as GTG, given this doesn't touch any actual code. |
|
Appveyor was continuing to show up in PR checks, I thought it might be a PR-level cache (if Appveyor has already run on a PR, it will continue to attempt to do so), but then I started seeing it on fully fresh branches created after this was merged. The first thing I found that was likely to work was: log in to Appveyor and revoke permissions for the app to this repo (originally granted by Arun some time ago). So if we decide to restore Appveyor, we'll have to re-grant those permissions to, as a note for posterity. |

Closes #5998
The first commit (c4283ee) left Appveyor intact to check comparative Windows CI timing of Appveyor vs. Windows, here's those timings:
i.e. roughly the same, therefore we should just drop Appveyor for simplicity.