Use early exit to get auto-print output for 'main' branch#6021
Merged
MichaelChirico merged 6 commits intomasterfrom Apr 3, 2024
Merged
Use early exit to get auto-print output for 'main' branch#6021MichaelChirico merged 6 commits intomasterfrom
MichaelChirico merged 6 commits intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6021 +/- ##
==========================================
- Coverage 97.53% 97.53% -0.01%
==========================================
Files 80 80
Lines 14916 14915 -1
==========================================
- Hits 14548 14547 -1
Misses 368 368 ☔ View full report in Codecov by Sentry. |
jangorecki
reviewed
Mar 27, 2024
jangorecki
approved these changes
Apr 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed in #5971 (comment) that we appear to be missing some output because the failure happens inside
if()...➡️ auto-print doesn't do anything.We should prefer auto-print to happen in the "main" execution path for these scripts (i.e. the one that runs on CRAN by default), so here I re-arranged the branches to get this to happen.