extend UnsplashBridge (II)#1813
Merged
Bockiii merged 11 commits intoRSS-Bridge:masterfrom Apr 5, 2022
langfingaz:unsplash
Merged
extend UnsplashBridge (II)#1813Bockiii merged 11 commits intoRSS-Bridge:masterfrom langfingaz:unsplash
Bockiii merged 11 commits intoRSS-Bridge:masterfrom
langfingaz:unsplash
Conversation
Thanks @nel50n for his UnsplashBridge! This Commit is mainly based on his work. Signed-off-by: langfingaz <daniel@systemli.org>
+ filter photo stream for username + change image preview quality + add link to user, location (if present), link to photo on unsplash to $item['content'] Signed-off-by: langfingaz <daniel@systemli.org>
Functionality is now merged into UnsplashBridge
Contributor
|
Hi again, @langfingaz! Sorry for long delay. Could you lint your code please for travis to show green tick instead of red cross? |
Pull request artifacts
|
Contributor
|
Hi, I fixed the merge issues, please check if the bridge still does what it should do @langfingaz . Additionally, please use either exampleValue OR defaultValue for a given parameter, not both. Also, please use a value that would generate an actual feed (from the current username example "unsplash" will produce something, while "someuser" will probably not). |
Bockiii
reviewed
Apr 5, 2022
Bockiii
reviewed
Apr 5, 2022
this is just to kick off another round of checks.
Bockiii
reviewed
Apr 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased pull request #1744.
Summary of changes: