Skip to content

extend UnsplashBridge#1744

Closed
langfingaz wants to merge 26 commits intoRSS-Bridge:masterfrom
langfingaz:master
Closed

extend UnsplashBridge#1744
langfingaz wants to merge 26 commits intoRSS-Bridge:masterfrom
langfingaz:master

Conversation

@langfingaz
Copy link
Contributor

@langfingaz langfingaz commented Sep 17, 2020

Thanks @nel50n for his UnsplashBridge! The commit is mainly based on his work.

As I this new bridge is based on UnsplashBridge.php, I left the MAINTAINER in line 6 to @nel50n . What do you think, shall I change this to me or leave it as is?

Signed-off-by: langfingaz daniel@systemli.org

@langfingaz
add Bridge: Image feed of Unsplash user
ab2b06c 
Thanks @nel50n for his UnsplashBridge! This Commit is mainly based on his work.

Signed-off-by: langfingaz <daniel@systemli.org>
@langfingaz
Copy link
Contributor Author

langfingaz commented Sep 17, 2020

In this bridge one can "follow" a username on https://unsplash.com receiving new images.

Here is one example of a running rss-bridge instance with this bridge enabled: https://rss.privacy1st.de/?action=display&bridge=UnsplashUser&u=h4mmiidd&m=20&w=1920&q=75&format=Html

@langfingaz
Copy link
Contributor Author

langfingaz commented Sep 17, 2020

And I'm not sure, but maybe one could merge this bridge into the already existing UnsplashBridge so that one can select if one would like to get the latest unsplas images or new images from a specific user. Help or ideas on how to do this are welcome!

@em92
Copy link
Contributor

em92 commented Sep 18, 2020

I left the MAINTAINER in line 6 to @nel50n . What do you think, shall I change this to me or leave it as is?

Generally speaking, if you are making new bridge, you should set MAINTAINER to yourself.

And I'm not sure, but maybe one could merge this bridge into the already existing UnsplashBridge

You can add param like "Filter by Username (optional)" or "Username (optional)" and defaultValue = "". Then you can change api source depending if this param is given.

@langfingaz
extend UnsplashBridge:
9ce1b9b 
+ filter photo stream for username
+ change image preview quality
+ add link to user, location (if present), link to photo on unsplash to $item['content']

Signed-off-by: langfingaz <daniel@systemli.org>
@langfingaz
Copy link
Contributor Author

langfingaz commented Sep 18, 2020 •
edited
Loading

You can add param like "Filter by Username (optional)" or "Username (optional)" and defaultValue = "". Then you can change api source depending if this param is given.

All right, I did some more work on the UnsplashBridge and merged my new UnsplashUserBridge into the already existing UnsplashBridge.

Generally speaking, if you are making new bridge, you should set MAINTAINER to yourself.

And I'm now added as second MAINTAINER.

You can test the modified UnsplashBridge here: https://rss.privacy1st.de

@langfingaz
Delete UnsplashUserBridge.php
7e0d382 
Functionality is now merged into UnsplashBridge
@langfingaz langfingaz changed the title add Bridge: Image feed of Unsplash user extende UnsplashBridge Sep 21, 2020
@langfingaz langfingaz changed the title extende UnsplashBridge extend UnsplashBridge Sep 21, 2020
@em92
Copy link
Contributor

em92 commented Oct 19, 2020

Hi, @langfingaz ! Could you please rebase your PR?

I have recently fixed Travis CI. It runs some tests and linting checks.

theScrabi and others added 20 commits October 21, 2020 14:08
@theScrabi @langfingaz
[NordbayernBridge] Fix images and newsblock order (#1741)
9ad2a6d
@VerifiedJoseph @langfingaz
[SoundcloudBridge] Fix bridge not returning tracks (#1757)
4a9669f 
+ Use artwork for enclosure
@arnd-s @langfingaz
[TwitterBridge] URL to js file with apikey changed again (#1764)
8afc534
@Ololbu @langfingaz
[FicbookBridge] Fix data getting and months (#1765)
3dee974
@ORelio @langfingaz
[NextINpact] Fix subtitle extraction in #LeBrief (#1780)
036e57a 
The bridge was taking another article abstract as subtitle for #LeBrief articles
@triatic @langfingaz
[TwitterBridge] Optimise regular expression code (#1768)
3276198 
* [TwitterBridge] Optimise regular expression code

Optimise regular expression search code so adding new URLs is cleaner
@corenting @langfingaz
[NasaApodBridge] Fix header being parsed as item (#1586)
56e52d2
@corenting @langfingaz
[core] Use Parsedown for Markdown parsing (#1783)
584453a
@csisoap @langfingaz
[NasaApodBridge] Fix broken image link (#1778)
d01e4ba
@otakuf @langfingaz
[AlbionOnlineBridge] New bridge (#1769)
7080301
@VerifiedJoseph @langfingaz
[HeiseBridge] Fix multi-page article fetching (#1767)
9374235 
Fixes multi-page article fetching by adding '&seite=all' to  article URL.
@Ololbu @langfingaz
[FicbookBridge] Add getName implementation (#1771)
c69c10f
@corenting @langfingaz
[DribbbleBridge] Fix picture parsing (#1787)
b62920e
@kolarcz @langfingaz
[CeskaTelevizeBridge] Add New bridge (#1784)
b65b485
@ORelio @langfingaz
[ZDNet] Fix article layout (#1793)
5db3718
@em92 @langfingaz
[.travis] Fix several phpcs and phpunit errors (#1799)
0b7f50b
@VerifiedJoseph @langfingaz
[KoreusBridge + VarietyBridge] Use HTTPS when fetching feedburner fee…
8f1396f 
…ds (#1797)
@langfingaz
[FacebookBridge] Handle mobile links and unify host validation (#1789)
69d33fe
@gsantner @langfingaz
[NineGagBridge] In post URI replace scheme from "http" to "https"
fed0da2
@em92 @langfingaz
[NineGagBridge] Lint previous commit
b5da6b1
@langfingaz langfingaz mentioned this pull request Oct 21, 2020
Merged
@langfingaz
Copy link
Contributor Author

langfingaz commented Oct 21, 2020

Well, I'm sorry that I somehow failed rebasing my changes... The master branch of my forked repo is now 26 (and not 3) commits ahead of RSS-Bridge:master.

I created a branch langfingaz/unsplash which is 3 commits ahead of RSS-Bridge:master.
Probably it better to create a new pull request from within that branch and close this pull request to keep it cleaner?

Sorry for the inconvenience.

@em92 em92 closed this Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.