[Core] Use Parsedown for Markdown parsing#1783
Merged
em92 merged 1 commit intoRSS-Bridge:masterfrom Oct 9, 2020
corenting:markdown_parsing
Merged
[Core] Use Parsedown for Markdown parsing#1783em92 merged 1 commit intoRSS-Bridge:masterfrom corenting:markdown_parsing
em92 merged 1 commit intoRSS-Bridge:masterfrom
corenting:markdown_parsing
Conversation
Contributor
|
Hi, @corenting ! |
Contributor
Author
Oops, I just repushed the branch with the correct files. |
Contributor
|
gj @corenting ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RainbowSixSiege and NyaaTorrents website used a common snippet to parse markdown using some regex. This resulted in some errors during the parsing of some contents.
This PR aims to replace this custom code with the Parsedown. I had to change the bridges a little bit as the new parser had troubles with HTML escape characters in NyaaTorrents and with line breaks in RainbowSixSiege.