[WordPress] Limit feed to 20 items#1801
Merged
em92 merged 3 commits intoRSS-Bridge:masterfrom Oct 21, 2020
ORelio:master
Merged
[WordPress] Limit feed to 20 items#1801em92 merged 3 commits intoRSS-Bridge:masterfrom ORelio:master
em92 merged 3 commits intoRSS-Bridge:masterfrom
ORelio:master
Conversation
Very large feeds will fail to load otherwise
Very large feeds will fail to load otherwise
Contributor
Author
|
Sure, done. Now the feed is truncated to 20 items. |
Contributor
There was a problem hiding this comment.
You can use collectExpandableDatas() to limit number of items returned, its simpler than your current method.
try{
$this->collectExpandableDatas($this->getURI() . '/feed/atom/', 20);
} catch (Exception $e) {
$this->collectExpandableDatas($this->getURI() . '/?feed=atom', 20);
}
Contributor
Author
|
Oh nice, thanks @VerifiedJoseph for the tip! Done. |
em92
approved these changes
Oct 21, 2020
Contributor
|
Thanks @ORelio and @VerifiedJoseph ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered a WordPress site having all its articles from the beginning in its feed, which meant hundreds of entries.
Fetching all the articles is time consuming, so the feed failed to load in RSS-Bridge because of a script timeout.
This PR adds a limit of 20 items in WordPress bridge to keep load times reasonable and avoid hammering the target site.
Extra items are kept unexpanded so they will still be present in the feed.