Minor Test Suite Mod - Error Code Capture for all tests by r-abishek · Pull Request #635 · ROCm/rpp

r-abishek · 2025-11-04T20:50:51Z

This is a minor test-suite PR:

Adds error-code capture in test scripts for all C++ tests.

…tion

Return error status - Capture error status for each function invocation

Copilot

Pull Request Overview

This PR adds error code capture and reporting functionality to the RPP test suite. When RPP API functions return error status codes, they are now captured and reported with human-readable error messages before exiting.

Key Changes:

Added a global map rppStatusToString to convert RppStatus enum values to string representations
Modified all test files to capture return values from RPP API calls and check for errors
Enhanced error reporting with descriptive messages for debugging

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
utilities/test_suite/rpp_test_suite_common.h	Added `rppStatusToString` map for converting error codes to strings
utilities/test_suite/HOST/Tensor_voxel_host.cpp	Added error capture variable and error checking logic for voxel operations
utilities/test_suite/HOST/Tensor_misc_host.cpp	Added error capture variable and error checking logic for misc operations
utilities/test_suite/HOST/Tensor_image_host.cpp	Added error capture variable and error checking logic for image operations
utilities/test_suite/HOST/Tensor_audio_host.cpp	Added error capture variable and error checking logic for audio operations
utilities/test_suite/HIP/Tensor_voxel_hip.cpp	Added error capture variable and error checking logic for HIP voxel operations
utilities/test_suite/HIP/Tensor_misc_hip.cpp	Added error capture variable and error checking logic for HIP misc operations
utilities/test_suite/HIP/Tensor_image_hip.cpp	Added error capture variable and error checking logic for HIP image operations
utilities/test_suite/HIP/Tensor_audio_hip.cpp	Added error capture variable and error checking logic for HIP audio operations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

utilities/test_suite/rpp_test_suite_common.h

utilities/test_suite/HOST/Tensor_voxel_host.cpp

utilities/test_suite/HOST/Tensor_misc_host.cpp

utilities/test_suite/HOST/Tensor_image_host.cpp

utilities/test_suite/HOST/Tensor_audio_host.cpp

utilities/test_suite/HIP/Tensor_voxel_hip.cpp

utilities/test_suite/HIP/Tensor_misc_hip.cpp

utilities/test_suite/HIP/Tensor_image_hip.cpp

utilities/test_suite/HIP/Tensor_audio_hip.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 9 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

utilities/test_suite/rpp_test_suite_common.h

utilities/test_suite/HOST/Tensor_voxel_host.cpp

utilities/test_suite/HOST/Tensor_misc_host.cpp

utilities/test_suite/HOST/Tensor_image_host.cpp

utilities/test_suite/HOST/Tensor_audio_host.cpp

utilities/test_suite/HIP/Tensor_voxel_hip.cpp

utilities/test_suite/HIP/Tensor_misc_hip.cpp

utilities/test_suite/HIP/Tensor_image_hip.cpp

utilities/test_suite/HIP/Tensor_audio_hip.cpp

CI Fixes - Error Capture PR

Copilot

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

utilities/test_suite/HOST/Tensor_voxel_host.cpp

utilities/test_suite/HOST/Tensor_misc_host.cpp

utilities/test_suite/HOST/Tensor_image_host.cpp

utilities/test_suite/HOST/Tensor_audio_host.cpp

utilities/test_suite/HIP/Tensor_voxel_hip.cpp

utilities/test_suite/HIP/Tensor_misc_hip.cpp

utilities/test_suite/HIP/Tensor_image_hip.cpp

utilities/test_suite/HIP/Tensor_audio_hip.cpp

Modify the print statements

LakshmiKumar23 · 2025-11-06T00:01:15Z

utilities/test_suite/HOST/Tensor_voxel_host.cpp

    set_generic_descriptor(descriptorPtr3D, batchSize, maxX, maxY, maxZ, numChannels, offsetInBytes, layoutType, BitDepthTestMode);

-    // update funcName based on bitdepth and layout
+    string func = funcName;


why are we doing this extra copy?

We have done this copy to maintain convention/consistency across the test suite

funcName is name of the functionality itself (For eg "brightness") and is used as a parameter for helper functions in the other test scripts (audio/image/misc)

func is name of the functionality augmented with the specific test case i.e for F16 PKD3 to PLN3, func would read as brightness_f16_Tensor_HOST_PKD3_toPLN3

Thanks

Replied/Resolved

codecov · 2025-11-13T23:44:35Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #635   +/-   ##
========================================
  Coverage    88.24%   88.24%           
========================================
  Files          195      195           
  Lines        82712    82712           
========================================
+ Hits         72985    72987    +2     
+ Misses        9727     9725    -2

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

kiritigowda · 2025-11-17T18:07:28Z

@r-abishek - please resolve conflicts

* Updates to capture error code * Intialize RPP_SUCCESS as default value * Update the code to display error status as part of the C++ code execution * Update rpp_test_suite_common.h * Update utilities/test_suite/HIP/Tensor_audio_hip.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HIP/Tensor_image_hip.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HIP/Tensor_misc_hip.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HIP/Tensor_voxel_hip.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HOST/Tensor_audio_host.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HOST/Tensor_image_host.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HOST/Tensor_misc_host.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HOST/Tensor_voxel_host.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fixes for CI issues * Restore naming convention in voxel test suite * Fix compilation issues * Update the code to use func for funcName * Modify error message * Modify the print statements --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

* F16 variants - Update loads and stores to AVX2 - Group 4 (#627) * Make changes for exposure, log and spatter * Updates for crop mirror normalize * Fix memory issues with log 1D * Remove changes for crop mirror normalize and restore rpp_cpu_simd_load_store.hpp * Update the alignedLength for log --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com> * Package - Enable Lintian Support rpp (#633) * fix lintian errors * fix lintian overrides static error * lintian errors fixed * move lintian overrides into if deb check * use existing changelog. fix formatting * not installing lintian overrides. keeping original changelog name * remove overrides --------- Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Docs - Bump rocm-docs-core[api_reference] from 1.27.0 to 1.29.0 in /docs/sphinx (#638) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.27.0 to 1.29.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.27.0...v1.29.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.29.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Test suite - Add QA pass/fail tests for F32 bit depth (#631) * Added golden outputs and resolved HOST backend * Updated bin files for median filter and resize crop mirror * Fix for median filter F32 QA * Updated bin files * Updated rcm review comments * Updated comments for rmn * Modified bitdepths and resolved review comments * Fix typo * resolve review comments --------- Co-authored-by: sampath117 <snehaa@multicorewareinc.com> Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com> * Test Suite - Error Code Capture for all tests (#635) * Updates to capture error code * Intialize RPP_SUCCESS as default value * Update the code to display error status as part of the C++ code execution * Update rpp_test_suite_common.h * Update utilities/test_suite/HIP/Tensor_audio_hip.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HIP/Tensor_image_hip.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HIP/Tensor_misc_hip.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HIP/Tensor_voxel_hip.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HOST/Tensor_audio_host.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HOST/Tensor_image_host.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HOST/Tensor_misc_host.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HOST/Tensor_voxel_host.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fixes for CI issues * Restore naming convention in voxel test suite * Fix compilation issues * Update the code to use func for funcName * Modify error message * Modify the print statements --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * F16 variants - Update loads and stores to AVX2 - Group 5 (#637) * Updates for crop mirror normalize * Updated flip F16 rawC and load store modifications * Updated blend with AVX support for F16 bitdepth * Updated color cast with AVX support for F16 bitdepth * Remove empty lines * Update comments * Fix comment in common function --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Docs - Bump rocm-docs-core[api_reference] from 1.29.0 to 1.30.0 in /docs/sphinx (#640) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.29.0 to 1.30.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.29.0...v1.30.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.30.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * HOST and HIP - pinned buffers for respective API (#628) * Removed memcpy and used hipHostMalloc for allocation : blend * Removed memcpy and used hipHostMalloc for allocation : brightness * Removed memcpy and used hipHostMalloc for allocation : color cast * Removed memcpy and used hipHostMalloc for allocation : color twist * Removed memcpy and used hipHostMalloc for allocation : contrast * Removed memcpy and used hipHostMalloc for allocation : crop mirror normalize * Removed memcpy and used hipHostMalloc for allocation : Exposure * Removed memcpy and used hipHostMalloc for allocation : Gamma correction * Removed memcpy and used hipHostMalloc for allocation : gaussian filter * Removed memcpy and used hipHostMalloc for allocation : Noise * Removed memcpy and used hipHostMalloc for allocation : Non linear blend * Removed memcpy and used hipHostMalloc for allocation : Resize mirror normalize * Removed memcpy and used hipHostMalloc for allocation : Water * Added hipHostFree for all kernels in test suite * Added hipHostFree for all kernels in test suite * Removed memcpy and used hipHostMalloc for allocation : Flip, spatter, rcm, color temperature * Resolved copilot review comments * Updated version * Removed unused parameter * Updated version in cmakeList * removed the host to device mem copies for warp affine and rotate * Updated version * Removed comment * Updated Chnagelog file * Update patch version from 2.2.0 to 2.2.1 * Update CHANGELOG * Address copilot comments for HIP HOST consistent allocation * Documentation changes for updated memcpy changes * Update ricap outer API to use pinned memory and remove mem copy * Fix memory allocation and deallocation for permutationTensor * Update api/rppt_tensor_effects_augmentations.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix spelling of noiseProbability and saltProbability * Fix deallocation --------- Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: hmaddise <HazarathKumar.Maddisetty@amd.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Docs - Bump rocm-docs-core[api_reference] from 1.30.0 to 1.30.1 in /docs/sphinx (#643) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.30.0 to 1.30.1. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.30.0...v1.30.1) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.30.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * CMakelists - Add optional GPU targets (#641) * add optional gpu targets * add addiitonal gpu targets * Rename function - hip_exec_roi_converison_ltrb_to_xywh to hip_exec_roi_conversion_ltrb_to_xywh (#645) Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> * Docs - Update CHANGELOG.md (#646) Updates --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Abishek <52214183+r-abishek@users.noreply.github.com> Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com> Co-authored-by: jonatluu <jonatluu@amd.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sampath117 <snehaa@multicorewareinc.com> Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: hmaddise <HazarathKumar.Maddisetty@amd.com>

Srihari-mcw and others added 4 commits November 2, 2025 23:22

Updates to capture error code

23869e5

Intialize RPP_SUCCESS as default value

f799e22

Update the code to display error status as part of the C++ code execu…

5692303

…tion

Merge pull request #518 from Srihari-mcw/return_error_status

622d597

Return error status - Capture error status for each function invocation

r-abishek requested review from Copilot and rrawther November 4, 2025 20:50

r-abishek added the ci:precheckin label Nov 4, 2025

Copilot AI reviewed Nov 4, 2025

View reviewed changes

r-abishek and others added 9 commits November 4, 2025 13:03

Update rpp_test_suite_common.h

11b5de6

Update utilities/test_suite/HIP/Tensor_audio_hip.cpp

5f4f3da

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update utilities/test_suite/HIP/Tensor_image_hip.cpp

fe01fc3

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update utilities/test_suite/HIP/Tensor_misc_hip.cpp

e319335

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update utilities/test_suite/HIP/Tensor_voxel_hip.cpp

532d9f2

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update utilities/test_suite/HOST/Tensor_audio_host.cpp

518af6c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update utilities/test_suite/HOST/Tensor_image_host.cpp

777c7dc

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update utilities/test_suite/HOST/Tensor_misc_host.cpp

46f104f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update utilities/test_suite/HOST/Tensor_voxel_host.cpp

2082bc8

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

r-abishek requested a review from Copilot November 4, 2025 21:09

Copilot AI reviewed Nov 4, 2025

View reviewed changes

Srihari-mcw and others added 7 commits November 5, 2025 07:03

Fixes for CI issues

2063dcb

Restore naming convention in voxel test suite

8d979ad

Fix compilation issues

fb7b4bd

Update the code to use func for funcName

232005a

Modify error message

2161fc6

Merge pull request #519 from Srihari-mcw/error_capture_ci_fixes

d3d9268

CI Fixes - Error Capture PR

Modify the print statements

a9e7ab1

r-abishek requested a review from Copilot November 5, 2025 06:40

Copilot AI reviewed Nov 5, 2025

View reviewed changes

Merge pull request #521 from Srihari-mcw/error_capture_ci_fixes

3fe207e

Modify the print statements

kiritigowda self-assigned this Nov 5, 2025

LakshmiKumar23 reviewed Nov 6, 2025

View reviewed changes

kiritigowda and others added 2 commits November 13, 2025 10:10

Merge branch 'develop' into ar/test_suite_mods_14_error_code

c590c3f

Merge branch 'develop' into ar/test_suite_mods_14_error_code

91cd6f6

Merge branch 'develop' into ar/test_suite_mods_14_error_code

1c941fb

rrawther approved these changes Nov 20, 2025

View reviewed changes

kiritigowda merged commit 6574c1c into ROCm:develop Nov 21, 2025
9 checks passed

Conversation

r-abishek commented Nov 4, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LakshmiKumar23 Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Srihari-mcw Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Srihari-mcw Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kiritigowda commented Nov 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Nov 13, 2025 •

edited

Loading