Test suite - Add QA pass/fail tests for F32 bit depth by r-abishek · Pull Request #631 · ROCm/rpp

r-abishek · 2025-10-24T05:52:06Z

The PR adds necessary changes to pass internal QA testing support for F32 bit depth for next set of 8 functions - Color Jitter, Crop mirror normalize, Erase, Gamma correction, Lut, Resize mirror normalize, Slice, Median Filter.

Add range checks rpp_pixel_check_0to1 to ensure F32 bit depth QA test pass.
Add necessary bin files for reference output.

…_set2

F32 QA Test suite upgradation set 4

Copilot

Pull Request Overview

This PR adds QA test support for F32 bit depth across 8 image processing functions (Color Jitter, Crop mirror normalize, Erase, Gamma correction, Lut, Resize mirror normalize, Slice, Median Filter). The changes fix bugs in conditional checks, correct median filter logic, and add pixel range validation to ensure F32 output values remain within the 0-1 range.

Key changes:

Fixed duplicate conditional checks that incorrectly tested U8_TO_F16 instead of U8_TO_F32
Corrected median filter algorithm by swapping min/max function calls
Added rpp_pixel_check_0to1 boundary validation after color transformations
Adjusted resize boundary limits to prevent out-of-bounds reads during bilinear interpolation

Reviewed Changes

Copilot reviewed 5 out of 16 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
runImageTests.py	Changed layout parameter to layout.value when calling run_performance_test
Tensor_image_host.cpp	Fixed three instances of incorrect U8_TO_F16 checks that should be U8_TO_F32
median_filter.cpp	Corrected median filter algorithm by swapping min/max functions
resize_mirror_normalize.cpp	Added pixel range checks and adjusted boundary limits for safe bilinear interpolation
color_jitter.cpp	Added pixel range validation after color jitter transformations

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

utilities/test_suite/HOST/runImageTests.py

codecov · 2025-10-24T08:26:49Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #631      +/-   ##
===========================================
+ Coverage    88.22%   88.24%   +0.02%     
===========================================
  Files          195      195              
  Lines        82704    82712       +8     
===========================================
+ Hits         72962    72985      +23     
+ Misses        9742     9727      -15

Files with missing lines	Coverage Δ
src/modules/tensor/cpu/kernel/color_jitter.cpp	`100.00% <100.00%> (ø)`
...ules/tensor/cpu/kernel/resize_mirror_normalize.cpp	`66.85% <100.00%> (+0.09%)`	⬆️
src/modules/tensor/hip/kernel/median_filter.cpp	`99.64% <ø> (ø)`

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

F32 QA PR: Resolve Copilot review comments

* Added golden outputs and resolved HOST backend * Updated bin files for median filter and resize crop mirror * Fix for median filter F32 QA * Updated bin files * Updated rcm review comments * Updated comments for rmn * Modified bitdepths and resolved review comments * Fix typo * resolve review comments --------- Co-authored-by: sampath117 <snehaa@multicorewareinc.com> Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com>

* F16 variants - Update loads and stores to AVX2 - Group 4 (#627) * Make changes for exposure, log and spatter * Updates for crop mirror normalize * Fix memory issues with log 1D * Remove changes for crop mirror normalize and restore rpp_cpu_simd_load_store.hpp * Update the alignedLength for log --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com> * Package - Enable Lintian Support rpp (#633) * fix lintian errors * fix lintian overrides static error * lintian errors fixed * move lintian overrides into if deb check * use existing changelog. fix formatting * not installing lintian overrides. keeping original changelog name * remove overrides --------- Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Docs - Bump rocm-docs-core[api_reference] from 1.27.0 to 1.29.0 in /docs/sphinx (#638) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.27.0 to 1.29.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.27.0...v1.29.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.29.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Test suite - Add QA pass/fail tests for F32 bit depth (#631) * Added golden outputs and resolved HOST backend * Updated bin files for median filter and resize crop mirror * Fix for median filter F32 QA * Updated bin files * Updated rcm review comments * Updated comments for rmn * Modified bitdepths and resolved review comments * Fix typo * resolve review comments --------- Co-authored-by: sampath117 <snehaa@multicorewareinc.com> Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com> * Test Suite - Error Code Capture for all tests (#635) * Updates to capture error code * Intialize RPP_SUCCESS as default value * Update the code to display error status as part of the C++ code execution * Update rpp_test_suite_common.h * Update utilities/test_suite/HIP/Tensor_audio_hip.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HIP/Tensor_image_hip.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HIP/Tensor_misc_hip.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HIP/Tensor_voxel_hip.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HOST/Tensor_audio_host.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HOST/Tensor_image_host.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HOST/Tensor_misc_host.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HOST/Tensor_voxel_host.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fixes for CI issues * Restore naming convention in voxel test suite * Fix compilation issues * Update the code to use func for funcName * Modify error message * Modify the print statements --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * F16 variants - Update loads and stores to AVX2 - Group 5 (#637) * Updates for crop mirror normalize * Updated flip F16 rawC and load store modifications * Updated blend with AVX support for F16 bitdepth * Updated color cast with AVX support for F16 bitdepth * Remove empty lines * Update comments * Fix comment in common function --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Docs - Bump rocm-docs-core[api_reference] from 1.29.0 to 1.30.0 in /docs/sphinx (#640) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.29.0 to 1.30.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.29.0...v1.30.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.30.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * HOST and HIP - pinned buffers for respective API (#628) * Removed memcpy and used hipHostMalloc for allocation : blend * Removed memcpy and used hipHostMalloc for allocation : brightness * Removed memcpy and used hipHostMalloc for allocation : color cast * Removed memcpy and used hipHostMalloc for allocation : color twist * Removed memcpy and used hipHostMalloc for allocation : contrast * Removed memcpy and used hipHostMalloc for allocation : crop mirror normalize * Removed memcpy and used hipHostMalloc for allocation : Exposure * Removed memcpy and used hipHostMalloc for allocation : Gamma correction * Removed memcpy and used hipHostMalloc for allocation : gaussian filter * Removed memcpy and used hipHostMalloc for allocation : Noise * Removed memcpy and used hipHostMalloc for allocation : Non linear blend * Removed memcpy and used hipHostMalloc for allocation : Resize mirror normalize * Removed memcpy and used hipHostMalloc for allocation : Water * Added hipHostFree for all kernels in test suite * Added hipHostFree for all kernels in test suite * Removed memcpy and used hipHostMalloc for allocation : Flip, spatter, rcm, color temperature * Resolved copilot review comments * Updated version * Removed unused parameter * Updated version in cmakeList * removed the host to device mem copies for warp affine and rotate * Updated version * Removed comment * Updated Chnagelog file * Update patch version from 2.2.0 to 2.2.1 * Update CHANGELOG * Address copilot comments for HIP HOST consistent allocation * Documentation changes for updated memcpy changes * Update ricap outer API to use pinned memory and remove mem copy * Fix memory allocation and deallocation for permutationTensor * Update api/rppt_tensor_effects_augmentations.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix spelling of noiseProbability and saltProbability * Fix deallocation --------- Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: hmaddise <HazarathKumar.Maddisetty@amd.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Docs - Bump rocm-docs-core[api_reference] from 1.30.0 to 1.30.1 in /docs/sphinx (#643) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.30.0 to 1.30.1. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.30.0...v1.30.1) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.30.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * CMakelists - Add optional GPU targets (#641) * add optional gpu targets * add addiitonal gpu targets * Rename function - hip_exec_roi_converison_ltrb_to_xywh to hip_exec_roi_conversion_ltrb_to_xywh (#645) Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> * Docs - Update CHANGELOG.md (#646) Updates --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Abishek <52214183+r-abishek@users.noreply.github.com> Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com> Co-authored-by: jonatluu <jonatluu@amd.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sampath117 <snehaa@multicorewareinc.com> Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: hmaddise <HazarathKumar.Maddisetty@amd.com>

snehaa8 and others added 12 commits August 13, 2025 11:46

Added golden outputs and resolved HOST backend

c557358

Merge remote-tracking branch 'origin/develop' into apr/f32_qa_set2

7bc5f63

Merge branch 'develop' of https://github.com/ROCm/rpp into apr/f32_qa…

98f2ab2

…_set2

Updated bin files for median filter and resize crop mirror

c1fcb1d

Fix for median filter F32 QA

3c9f971

Merge branch 'develop' of https://github.com/ROCm/rpp into apr/f32_qa…

dd6bf62

…_set2

Updated bin files

489fa99

Updated rcm review comments

f06268c

Updated comments for rmn

6ad3d2a

Modified bitdepths and resolved review comments

ff9f4bf

Fix typo

6f1cf48

Merge pull request #508 from RooseweltMcW/apr/f32_qa_set2

2ccb7aa

F32 QA Test suite upgradation set 4

r-abishek requested a review from Copilot October 24, 2025 05:52

r-abishek added the ci:precheckin label Oct 24, 2025

Copilot AI reviewed Oct 24, 2025

View reviewed changes

utilities/test_suite/HOST/runImageTests.py Show resolved Hide resolved

HazarathKumarM and others added 2 commits October 24, 2025 15:43

resolve review comments

415ae9a

Merge pull request #511 from HazarathKumarM/hk/test_suite_12

270807c

F32 QA PR: Resolve Copilot review comments

kiritigowda assigned kiritigowda and LakshmiKumar23 Oct 28, 2025

Merge branch 'develop' into ar/test_suite_upgrade_12_f32qa

51e2e9e

kiritigowda unassigned LakshmiKumar23 Oct 28, 2025

kiritigowda requested a review from LakshmiKumar23 October 28, 2025 16:30

Merge branch 'develop' into ar/test_suite_upgrade_12_f32qa

86aeaa0

LakshmiKumar23 requested a review from rrawther October 29, 2025 21:57

Merge branch 'develop' into ar/test_suite_upgrade_12_f32qa

4efc60f

LakshmiKumar23 approved these changes Nov 5, 2025

View reviewed changes

kiritigowda and others added 2 commits November 13, 2025 10:08

Merge branch 'develop' into ar/test_suite_upgrade_12_f32qa

ff3a5c7

Merge branch 'develop' into ar/test_suite_upgrade_12_f32qa

3ee3fd5

kiritigowda merged commit 064bd15 into ROCm:develop Nov 17, 2025
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test suite - Add QA pass/fail tests for F32 bit depth#631

Test suite - Add QA pass/fail tests for F32 bit depth#631
kiritigowda merged 19 commits intoROCm:developfrom
r-abishek:ar/test_suite_upgrade_12_f32qa

r-abishek commented Oct 24, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

codecov bot commented Oct 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

r-abishek commented Oct 24, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

codecov bot commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Oct 24, 2025 •

edited

Loading