rocAL Serialize PR 1- Introduce EnumRegistry#390
Merged
kiritigowda merged 24 commits intoROCm:developfrom Oct 13, 2025
Merged
Conversation
Remove the usage of API enums in internal node files
Add support to register all internal enums
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
spolifroni-amd
left a comment
There was a problem hiding this comment.
There doesn't seem to be anything for docs to review, but I was wondering if this needed a changelog entry? it looks like some headers have changed.
Contributor
Author
Done |
spolifroni-amd
approved these changes
Oct 9, 2025
kiritigowda
added a commit
that referenced
this pull request
Oct 13, 2025
This reverts commit c21dec6.
kiritigowda
added a commit
that referenced
this pull request
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
NOTE: To be merged after PR #389