Skip to content

Refactor external enum usage in rocAL#389

Merged
kiritigowda merged 11 commits intoROCm:developfrom
fiona-gladwin:fg/enum_change
Oct 15, 2025
Merged

Refactor external enum usage in rocAL#389
kiritigowda merged 11 commits intoROCm:developfrom
fiona-gladwin:fg/enum_change

Conversation

@fiona-gladwin
Copy link
Copy Markdown
Contributor

@fiona-gladwin fiona-gladwin commented Oct 3, 2025 •
edited
Loading

Motivation

  • Remove the use of external enums present in rocal_api_types.h inside rocAL source code
  • Required to maintain separation between external and internal enums which helps in registering enums for pipeline serialization.

Technical Details

  • Introduction of internal enum classes (ResizeScalingMode, ResizeInterpolationType, MelScaleFormula, AudioBorderType, OutOfBoundsPolicy) in commons.h
  • Replacement of external enum types with internal equivalents across node implementations and API calls

fiona-gladwin and others added 4 commits September 22, 2025 02:30
@fiona-gladwin
Use enums present in commons.h
c4e55ca 
Remove the usage of API enums in internal node files
@fiona-gladwin
Remove unused include rocal_api_types.h
22af55b
@fiona-gladwin
Remove redundant static cast
cba503f 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@fiona-gladwin
Minor fix
2651138
@fiona-gladwin fiona-gladwin mentioned this pull request Oct 3, 2025
Merged
@LakshmiKumar23 LakshmiKumar23 self-requested a review October 3, 2025 16:14
rrawther
rrawther requested changes Oct 3, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@rrawther rrawther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a major change. Please add changelog and bump up the version

@fiona-gladwin fiona-gladwin requested a review from a team as a code owner October 7, 2025 09:35
@fiona-gladwin
Copy link
Copy Markdown
Contributor Author

fiona-gladwin commented Oct 7, 2025 •
edited
Loading

This is a major change. Please add changelog and bump up the version

@rrawther Updated Changelog and added to the 2.4.0 version

spolifroni-amd
spolifroni-amd requested changes Oct 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@spolifroni-amd spolifroni-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entry needs a bit more detail.

spolifroni-amd
spolifroni-amd previously approved these changes Oct 9, 2025
View reviewed changes
@kiritigowda
Copy link
Copy Markdown
Collaborator

kiritigowda commented Oct 13, 2025

@fiona-gladwin please resolve conflicts

@fiona-gladwin fiona-gladwin mentioned this pull request Oct 14, 2025
Merged
@kiritigowda kiritigowda self-assigned this Oct 15, 2025
@kiritigowda kiritigowda merged commit 08f9a35 into ROCm:develop Oct 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rrawther rrawther rrawther approved these changes

@spolifroni-amd spolifroni-amd spolifroni-amd left review comments

@kiritigowda kiritigowda Awaiting requested review from kiritigowda kiritigowda is a code owner

@LakshmiKumar23 LakshmiKumar23 Awaiting requested review from LakshmiKumar23

Assignees

@kiritigowda kiritigowda

Labels

ci:precheckin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@fiona-gladwin @kiritigowda @rrawther @spolifroni-amd @fgladwin @SundarRajan28