[ROCm] Disable MIOpen for empty tensors for RNN (#117672)#1388
Merged
pruthvistony merged 1 commit intorelease/2.2from Apr 8, 2024
Merged
Conversation
Some MIOpen RNN functions (lstm, rnn, gru) can't work with empty tensors and return error "MIOpen Error: Lengths must be > 0" This PR disables MIOpen tor empty tensors and force to use native methods The solution is based on condition of using CUDNN https://github.com/pytorch/pytorch/blob/3a52147cc59b240737602d3d046080bbf6f567f1/aten/src/ATen/native/TensorProperties.cpp#L91 It also fix [test_nn.py::TestNN::test_RNN_input_size_zero](https://github.com/pytorch/pytorch/blob/29fa6fbc4eda6c02ecdfd73b74a8702187c4fc44/test/test_nn.py#L4592) on ROCM Pull Request resolved: pytorch#117672 Approved by: https://github.com/cpuhrsch
pruthvistony
approved these changes
Apr 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix cherry-picked from upstream for release/2.2 branch
Some MIOpen RNN functions (lstm, rnn, gru) can't work with empty tensors and return error "MIOpen Error: Lengths must be > 0" This PR disables MIOpen tor empty tensors and force to use native methods.
Also fix test_nn.py::test_RNN_input_size_zero