[ROCm] Disable MIOpen for empty tensors for RNN#117672
Closed
dnikolaev-amd wants to merge 1 commit intopytorch:mainfrom
Closed
[ROCm] Disable MIOpen for empty tensors for RNN#117672dnikolaev-amd wants to merge 1 commit intopytorch:mainfrom
dnikolaev-amd wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/117672
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit ae14744 with merge base 79811e7 ( UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
|
@pytorchbot label ciflow/rocm |
|
Please seek CI approval before scheduling CIFlow labels |
Collaborator
|
@pytorchbot rebase |
Collaborator
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Collaborator
|
Successfully rebased |
d7bb0f6 to
ae14744
Compare
cpuhrsch
approved these changes
Jan 20, 2024
Collaborator
|
@pytorchbot merge -f "Two unstable suites failing" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
BLOrange-AMD
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Mar 1, 2024
Some MIOpen RNN functions (lstm, rnn, gru) can't work with empty tensors and return error "MIOpen Error: Lengths must be > 0" This PR disables MIOpen tor empty tensors and force to use native methods The solution is based on condition of using CUDNN https://github.com/pytorch/pytorch/blob/3a52147cc59b240737602d3d046080bbf6f567f1/aten/src/ATen/native/TensorProperties.cpp#L91 It also fix [test_nn.py::TestNN::test_RNN_input_size_zero](https://github.com/pytorch/pytorch/blob/29fa6fbc4eda6c02ecdfd73b74a8702187c4fc44/test/test_nn.py#L4592) on ROCM Pull Request resolved: pytorch#117672 Approved by: https://github.com/cpuhrsch
dnikolaev-amd
added a commit
to ROCm/pytorch
that referenced
this pull request
Apr 8, 2024
Some MIOpen RNN functions (lstm, rnn, gru) can't work with empty tensors and return error "MIOpen Error: Lengths must be > 0" This PR disables MIOpen tor empty tensors and force to use native methods The solution is based on condition of using CUDNN https://github.com/pytorch/pytorch/blob/3a52147cc59b240737602d3d046080bbf6f567f1/aten/src/ATen/native/TensorProperties.cpp#L91 It also fix [test_nn.py::TestNN::test_RNN_input_size_zero](https://github.com/pytorch/pytorch/blob/29fa6fbc4eda6c02ecdfd73b74a8702187c4fc44/test/test_nn.py#L4592) on ROCM Pull Request resolved: pytorch#117672 Approved by: https://github.com/cpuhrsch
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Apr 8, 2024
Some MIOpen RNN functions (lstm, rnn, gru) can't work with empty tensors and return error "MIOpen Error: Lengths must be > 0" This PR disables MIOpen tor empty tensors and force to use native methods The solution is based on condition of using CUDNN https://github.com/pytorch/pytorch/blob/3a52147cc59b240737602d3d046080bbf6f567f1/aten/src/ATen/native/TensorProperties.cpp#L91 It also fix [test_nn.py::TestNN::test_RNN_input_size_zero](https://github.com/pytorch/pytorch/blob/29fa6fbc4eda6c02ecdfd73b74a8702187c4fc44/test/test_nn.py#L4592) on ROCM Pull Request resolved: pytorch#117672 Approved by: https://github.com/cpuhrsch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some MIOpen RNN functions (lstm, rnn, gru) can't work with empty tensors and return error "MIOpen Error: Lengths must be > 0"
This PR disables MIOpen tor empty tensors and force to use native methods
The solution is based on condition of using CUDNN
pytorch/aten/src/ATen/native/TensorProperties.cpp
Line 91 in 3a52147
It also fix test_nn.py::TestNN::test_RNN_input_size_zero on ROCM
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang