Skip to content

Fix - mem leak#1585

Merged
kiritigowda merged 7 commits intoROCm:developfrom
sruthi0107:develop
Dec 3, 2025
Merged

Fix - mem leak#1585
kiritigowda merged 7 commits intoROCm:developfrom
sruthi0107:develop

Conversation

@sruthi0107
Copy link
Copy Markdown
Contributor

Motivation

To fix memory leaks in the amd_nn extension

Technical Details

Freed the miopen_handle in amd_nn/src/kernels.cpp when the reference count reaches zero.

Test Plan

Ran ctests and and valgrind on the NN extension tests

Test Result

All ctests pass

Submission Checklist

@LakshmiKumar23 LakshmiKumar23 added bugfix Bug fixes to existing features ci:precheckin labels Dec 2, 2025
@kiritigowda kiritigowda merged commit 7d2a113 into ROCm:develop Dec 3, 2025
9 of 11 checks passed
JeniferC99 pushed a commit that referenced this pull request Jan 22, 2026
* Docs - Bump rocm-docs-core[api_reference] from 1.27.0 to 1.29.0 in /docs/sphinx (#1577)

Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.27.0 to 1.29.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.27.0...v1.29.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.29.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Dependecies - Use OpenCV & FFMPEG only in Ubuntu (#1575)

* Dependecies - Use OpenCV & FFMPEG in Ubuntu

* Min Deps Mode - Support Min deps build

* CMakeLists - Fix

* Ubuntu - 22 Only support for extented support

* Package - Enable Lintian Support MIVisionX (#1573)

* lintian errors fix

* move overrides install

* use provided changelog and copyright. Fixed formatting

* keep changelog name. Don't install lintian overrides

* keep copyright.txt naming

* remove overrides

* remove overrides and addressing comments

---------

Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

* VX_Media - Add missing include directive (#1578)

Signed-off-by: Christian Heusel <christian@heusel.eu>

* Docs - Bump rocm-docs-core[api_reference] from 1.29.0 to 1.30.0 in /docs/sphinx (#1579)

Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.29.0 to 1.30.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.29.0...v1.30.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.30.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Docs - Bump rocm-docs-core[api_reference] from 1.30.0 to 1.30.1 in /docs/sphinx (#1583)

Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.30.0 to 1.30.1.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.30.0...v1.30.1)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.30.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Docs - Bump fonttools from 4.55.0 to 4.61.0 in /docs/sphinx (#1584)

Bumps [fonttools](https://github.com/fonttools/fonttools) from 4.55.0 to 4.61.0.
- [Release notes](https://github.com/fonttools/fonttools/releases)
- [Changelog](https://github.com/fonttools/fonttools/blob/main/NEWS.rst)
- [Commits](fonttools/fonttools@4.55.0...4.61.0)

---
updated-dependencies:
- dependency-name: fonttools
  dependency-version: 4.61.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* OpenVX - Fix Memory leak (#1580)

* Fix - Memory leak

* Removed comment

---------

Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

* VX_RPP - Update memory allocation for HIP augmentation parameters (#1570)

* Modified memory allocation to use hipHostMalloc for few functionalities

* Modified memory allocation to use hipHostMalloc for other functionalities

* Modified memory allocation to use hipHostMalloc for additional 3 kernels

* Modified memory allocation to use hipHostMalloc for 2 kernels additional parameters

* Updated version

* Modified blend to use AGO_TARGET_AFFINITY_GPU flag and removed usage of ENABLE_HIP

* Modified usage of AGO_TARGET_AFFINITY_GPU flag

* Updated ResizeCropMirror changes

* Removed nullPtr condition

* Updated Flip and colorTemperature

* updated version in RPP cmakelist

* Update two more kernels and CMake

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Change macro

* Update rpp package version to 2.2.1

---------

Co-authored-by: shobana-mcw <shobana@multicorewareinc.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* VX_NN - mem leak fix (#1585)

* Fix - Memory leak

* Removed comment

* Fix - mem leak

* Fix - mem leak

---------

Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

* CMakeLists - update GPU targets (#1581)

* upgrade mathjax version to 3.x to resolve a vulnerability (#1587)

* Upgrade MathJax to 3.x to resolve vulnerability (#1588)

* upgrade mathjax version to 3.x to resolve a vulnerability

* upgrade MathJax to 3.x

* VX_OpenCV & VX_Media - mem leak fix (#1586)

* Fix - Memory leak

* Removed comment

* Fix - mem leak

* Fix - mem leak

* VX_OpenCV - mem leak fix

* VX_OpenCV - mem leak fix

* VX_MEDIA - mem leak fix

* VX_MEDIA - mem leak fix

* Update amd_openvx_extensions/amd_media/decoder.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update OpenCV_goodFeaturesToTrackdetector.cpp

---------

Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Docs - Bump urllib3 from 2.5.0 to 2.6.0 in /docs/sphinx (#1589)

Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.5.0 to 2.6.0.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@2.5.0...2.6.0)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-version: 2.6.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Docs - Update CHANGELOG.md (#1590)

Updates for ROCm 7.2

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Christian Heusel <christian@heusel.eu>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jonatluu <jonatluu@amd.com>
Co-authored-by: Christian Heusel <christian@heusel.eu>
Co-authored-by: Sruthi Srinivasan <srutsrin@amd.com>
Co-authored-by: Sundar Rajan Vaithiyanathan <99159823+SundarRajan28@users.noreply.github.com>
Co-authored-by: shobana-mcw <shobana@multicorewareinc.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com>
Co-authored-by: alexxu-amd <159800977+alexxu-amd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Bug fixes to existing features ci:precheckin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants