Enable Lintian Support MIVisionX by jonatluu · Pull Request #1573 · ROCm/MIVisionX

jonatluu · 2025-10-28T19:00:21Z

Motivation

Install changelog, copyright, and lintian override files to fix lintian errors:
no-copyright-file
debian-changelog-file-missing
dir-or-file-in-opt

Technical Details

Added function configure_pkg to install changelog, copyright, and lintian override for debian

Test Plan

Verify lintian errors are fixed and changelog, copyright and lintian overrides are installed

Test Result

Lintian errors fixed changelog, copyright and lintian overrides are installed

Submission Checklist

Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

…MIVisionX into jonatluu/lintian_error

kiritigowda · 2025-11-03T17:46:25Z

@jonatluu -- failing Azure CI build -

CMake Error at cmake_install.cmake:94 (file):
  file INSTALL cannot copy file "/agent/_work/1/s/build/DEBIAN/mivisionx" to
  "/usr/share/lintian/overrides/mivisionx": Permission denied.


FAILED: CMakeFiles/install.util 
cd /agent/_work/1/s/build && /usr/bin/cmake -P cmake_install.cmake
ninja: build stopped: subcommand failed.

Copilot

Pull Request Overview

This PR adds Lintian support for Debian packaging by installing changelog, copyright, and lintian override files to fix lintian errors (no-copyright-file, debian-changelog-file-missing, dir-or-file-in-opt).

Key changes:

Added utils.cmake with functions for configuring Debian packaging files
Modified CMakeLists.txt to enable Lintian support and call the new configuration function

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.

File	Description
utils.cmake	New file containing `configure_pkg` and `set_debian_pkg_cmake_flags` functions for Debian packaging configuration
CMakeLists.txt	Includes utils.cmake, sets Lintian-related variables, and calls configure_pkg function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

utils.cmake

…MIVisionX into jonatluu/lintian_error

rrawther

@kiritigowda : I am not sure what is the impact of this PR. Can you please validate it

* Docs - Bump rocm-docs-core[api_reference] from 1.27.0 to 1.29.0 in /docs/sphinx (#1577) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.27.0 to 1.29.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.27.0...v1.29.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.29.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Dependecies - Use OpenCV & FFMPEG only in Ubuntu (#1575) * Dependecies - Use OpenCV & FFMPEG in Ubuntu * Min Deps Mode - Support Min deps build * CMakeLists - Fix * Ubuntu - 22 Only support for extented support * Package - Enable Lintian Support MIVisionX (#1573) * lintian errors fix * move overrides install * use provided changelog and copyright. Fixed formatting * keep changelog name. Don't install lintian overrides * keep copyright.txt naming * remove overrides * remove overrides and addressing comments --------- Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * VX_Media - Add missing include directive (#1578) Signed-off-by: Christian Heusel <christian@heusel.eu> * Docs - Bump rocm-docs-core[api_reference] from 1.29.0 to 1.30.0 in /docs/sphinx (#1579) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.29.0 to 1.30.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.29.0...v1.30.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.30.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Docs - Bump rocm-docs-core[api_reference] from 1.30.0 to 1.30.1 in /docs/sphinx (#1583) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.30.0 to 1.30.1. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.30.0...v1.30.1) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.30.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Docs - Bump fonttools from 4.55.0 to 4.61.0 in /docs/sphinx (#1584) Bumps [fonttools](https://github.com/fonttools/fonttools) from 4.55.0 to 4.61.0. - [Release notes](https://github.com/fonttools/fonttools/releases) - [Changelog](https://github.com/fonttools/fonttools/blob/main/NEWS.rst) - [Commits](fonttools/fonttools@4.55.0...4.61.0) --- updated-dependencies: - dependency-name: fonttools dependency-version: 4.61.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * OpenVX - Fix Memory leak (#1580) * Fix - Memory leak * Removed comment --------- Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * VX_RPP - Update memory allocation for HIP augmentation parameters (#1570) * Modified memory allocation to use hipHostMalloc for few functionalities * Modified memory allocation to use hipHostMalloc for other functionalities * Modified memory allocation to use hipHostMalloc for additional 3 kernels * Modified memory allocation to use hipHostMalloc for 2 kernels additional parameters * Updated version * Modified blend to use AGO_TARGET_AFFINITY_GPU flag and removed usage of ENABLE_HIP * Modified usage of AGO_TARGET_AFFINITY_GPU flag * Updated ResizeCropMirror changes * Removed nullPtr condition * Updated Flip and colorTemperature * updated version in RPP cmakelist * Update two more kernels and CMake * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Change macro * Update rpp package version to 2.2.1 --------- Co-authored-by: shobana-mcw <shobana@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * VX_NN - mem leak fix (#1585) * Fix - Memory leak * Removed comment * Fix - mem leak * Fix - mem leak --------- Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * CMakeLists - update GPU targets (#1581) * upgrade mathjax version to 3.x to resolve a vulnerability (#1587) * Upgrade MathJax to 3.x to resolve vulnerability (#1588) * upgrade mathjax version to 3.x to resolve a vulnerability * upgrade MathJax to 3.x * VX_OpenCV & VX_Media - mem leak fix (#1586) * Fix - Memory leak * Removed comment * Fix - mem leak * Fix - mem leak * VX_OpenCV - mem leak fix * VX_OpenCV - mem leak fix * VX_MEDIA - mem leak fix * VX_MEDIA - mem leak fix * Update amd_openvx_extensions/amd_media/decoder.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update OpenCV_goodFeaturesToTrackdetector.cpp --------- Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Docs - Bump urllib3 from 2.5.0 to 2.6.0 in /docs/sphinx (#1589) Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.5.0 to 2.6.0. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@2.5.0...2.6.0) --- updated-dependencies: - dependency-name: urllib3 dependency-version: 2.6.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Docs - Update CHANGELOG.md (#1590) Updates for ROCm 7.2 --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Christian Heusel <christian@heusel.eu> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jonatluu <jonatluu@amd.com> Co-authored-by: Christian Heusel <christian@heusel.eu> Co-authored-by: Sruthi Srinivasan <srutsrin@amd.com> Co-authored-by: Sundar Rajan Vaithiyanathan <99159823+SundarRajan28@users.noreply.github.com> Co-authored-by: shobana-mcw <shobana@multicorewareinc.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com> Co-authored-by: alexxu-amd <159800977+alexxu-amd@users.noreply.github.com>

jonatluu added 5 commits October 1, 2025 14:55

lintian errors fix

4b58f86

Merge branch 'ROCm:develop' into jonatluu/lintian_error

896cd7d

Merge branch 'ROCm:develop' into jonatluu/lintian_error

4907450

move overrides install

6c361dd

Merge branch 'jonatluu/lintian_error' of https://github.com/jonatluu/…

00c40fe

…MIVisionX into jonatluu/lintian_error

jonatluu requested review from kiritigowda and rrawther as code owners October 28, 2025 19:00

jonatluu changed the title ~~Enable Lintian Support~~ Enable Lintian Support MIVisionX Oct 28, 2025

kiritigowda added enhancement New feature or request ci:precheckin labels Oct 28, 2025

kiritigowda self-assigned this Oct 28, 2025

use provided changelog and copyright. Fixed formatting

fb9abae

kiritigowda marked this pull request as draft November 3, 2025 22:23

keep changelog name. Don't install lintian overrides

6e76849

jonatluu marked this pull request as ready for review November 12, 2025 03:11

jonatluu added 2 commits November 11, 2025 22:23

keep copyright.txt naming

602ff92

remove overrides

40528fe

kiritigowda requested a review from Copilot November 13, 2025 18:12

Copilot started reviewing on behalf of kiritigowda November 13, 2025 18:13 View session

Merge branch 'develop' into jonatluu/lintian_error

e918cc3

Copilot finished reviewing on behalf of kiritigowda November 13, 2025 18:14

Copilot AI reviewed Nov 13, 2025

View reviewed changes

kiritigowda and others added 3 commits November 13, 2025 13:05

Merge branch 'develop' into jonatluu/lintian_error

6368c6f

remove overrides and addressing comments

c99d7e1

Merge branch 'jonatluu/lintian_error' of https://github.com/jonatluu/…

bcf0df6

…MIVisionX into jonatluu/lintian_error

rrawther reviewed Nov 14, 2025

View reviewed changes

kiritigowda approved these changes Nov 17, 2025

View reviewed changes

kiritigowda merged commit f00be5f into ROCm:develop Nov 17, 2025
5 of 7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable Lintian Support MIVisionX#1573

Enable Lintian Support MIVisionX#1573
kiritigowda merged 13 commits intoROCm:developfrom
jonatluu:jonatluu/lintian_error

jonatluu commented Oct 28, 2025 •

edited

Loading

Uh oh!

kiritigowda commented Nov 3, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rrawther left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jonatluu commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

Uh oh!

kiritigowda commented Nov 3, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rrawther left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jonatluu commented Oct 28, 2025 •

edited

Loading