Skip to content

Shell updates#22

Merged
chrysn merged 6 commits intomainfrom
shell-updates
Jan 23, 2023
Merged

Shell updates#22
chrysn merged 6 commits intomainfrom
shell-updates

Conversation

@chrysn
Copy link
Copy Markdown
Member

@chrysn chrysn commented Oct 3, 2022

With GAT, we can do a bit better on some parts of the shell abstraction.

This is WIP, and preparing a breaking change (as the line buffer should really not need to be provided by the user for good usability).

@chrysn
Copy link
Copy Markdown
Member Author

chrysn commented Jan 23, 2023

As it is now, it should still be compatible (i.e. can go in without a breaking version bump) because merely a trait gained a defaulting associated constant. And the necessary version is in CI now, so chances are this can just go through.

The new recommended methods have slightly weird names (_providing_buffer), but once the now deprecated old methods are out, they can be renamed.

@chrysn chrysn marked this pull request as ready for review January 23, 2023 19:43
@chrysn chrysn merged commit 7b39d1e into main Jan 23, 2023
@chrysn chrysn deleted the shell-updates branch January 23, 2023 20:01
bors bot added a commit to RIOT-OS/RIOT that referenced this pull request Feb 1, 2023
19193: rust: Update dependencies, use riot-wrappers from git r=benpicco a=chrysn

### Contribution description

As riot-wrappers has advanced a bit since it was last released, Rust modules are switched to using it from git again. (This is a regular ping-pong between testing the latest release in RIOT master, and using released support crates when they're current).

This primarily updates riot-wrappers, which has accumulated several compatible changes. Several other crates receive updates as well.

### Testing procedure

* Green CI

### Issues/PRs references

Changes on the riot-wrappers side:

* RIOT-OS/rust-riot-wrappers#17
* RIOT-OS/rust-riot-wrappers#22
* RIOT-OS/rust-riot-wrappers#29
* RIOT-OS/rust-riot-wrappers#30

[edit: added:]

This also serves to help preparing a 0.8.1 release of riot-wrappers, which performs some deprecations so that a breaking 0.9 change can be done more effortlessly later on.

19214: cpu/gd32v: add periph_spi support r=benpicco a=gschorcht

### Contribution description

This PR provides the `periph_spi` support and is one of a bunch of PRs that complete the peripheral drivers for GD32VF103.

The driver is a modified version of the driver for STM32F1 with some changes that were necessary to get it working on GD32V.

### Testing procedure

`tests/periph_spi` as well as a test with any SPI sensor should work. `tests/driver_sdcard_spi` should work on `sipeed-longan-nano`.

### Issues/PRs references

Depeneds on PR #19216 

Co-authored-by: chrysn <chrysn@fsfe.org>
Co-authored-by: Gunar Schorcht <gunar@schorcht.net>
SimonIT pushed a commit to ATACAMA-Project/rust-riot-wrappers that referenced this pull request Oct 9, 2023
add ds18 wrapper

Closes RIOT-OS#22

See merge request atacama/rust-riot-wrappers!28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant