Conversation
Member
Author
|
CI is unreliable until RIOT-OS/RIOT#18678 is in, because versions mismatch. |
This is a precondition of the C code, and might be UB otherwise.
bors Bot
added a commit
to RIOT-OS/RIOT
that referenced
this pull request
Feb 1, 2023
19193: rust: Update dependencies, use riot-wrappers from git r=benpicco a=chrysn ### Contribution description As riot-wrappers has advanced a bit since it was last released, Rust modules are switched to using it from git again. (This is a regular ping-pong between testing the latest release in RIOT master, and using released support crates when they're current). This primarily updates riot-wrappers, which has accumulated several compatible changes. Several other crates receive updates as well. ### Testing procedure * Green CI ### Issues/PRs references Changes on the riot-wrappers side: * RIOT-OS/rust-riot-wrappers#17 * RIOT-OS/rust-riot-wrappers#22 * RIOT-OS/rust-riot-wrappers#29 * RIOT-OS/rust-riot-wrappers#30 [edit: added:] This also serves to help preparing a 0.8.1 release of riot-wrappers, which performs some deprecations so that a breaking 0.9 change can be done more effortlessly later on. 19214: cpu/gd32v: add periph_spi support r=benpicco a=gschorcht ### Contribution description This PR provides the `periph_spi` support and is one of a bunch of PRs that complete the peripheral drivers for GD32VF103. The driver is a modified version of the driver for STM32F1 with some changes that were necessary to get it working on GD32V. ### Testing procedure `tests/periph_spi` as well as a test with any SPI sensor should work. `tests/driver_sdcard_spi` should work on `sipeed-longan-nano`. ### Issues/PRs references Depeneds on PR #19216 Co-authored-by: chrysn <chrysn@fsfe.org> Co-authored-by: Gunar Schorcht <gunar@schorcht.net>
SimonIT
pushed a commit
to ATACAMA-Project/rust-riot-wrappers
that referenced
this pull request
Oct 9, 2023
Add TCS37727 Wrapper Closes RIOT-OS#17 See merge request atacama/rust-riot-wrappers!23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a precondition of the C code, and might be UB otherwise.
Explicitly checking might bring a performance impact, and removes us from being a zero-cost abstraction, but safety is a preeminent requirement for Rust wrappers.