@cladmi I have a huge problem here
this commit introduces i2C support in the Makefile.features for nucleo-f070 in the new_i2c_if branch.
But when I rebase the branch new_i2c_if3 to master I got this
the added line to Makefile.features is now to nucleo-f030 not nucleo-f070.
I guess rebase didn't do its job correctly but nucleo's board were renamed.
What can I do ?

EDIT: both links were inverted

My idea would be to try rebasing but forbid git to perform automatic merge, so that you still must verify each commit.
Maybe you can by putting "edit" for all commits except merges during the rebase and checking each commit… Not sure how "--preserve" likes this though.

Something that can help finding these, is https://stackoverflow.com/a/40183550/395687

git commit-tree riot/new_i2c_if3^{tree} -p riot/new_i2c_if  -p riot/master -m 'Is that ok?'

And doing git show GIVEN_HASH to see the difference between "merged" diff and "rebased" diff. Some lines have a ++ also. It can help narrowing down these issues.

@cladmi The I2C refactoring is now over and ready to be merged. The decision to add it to the incoming release belongs to you :)
Murdock is finally happy with this PR !

Do you have somewhere the list of tests that was run so they could be re-run in master ?
At least the easy ones and the one that got conflicts.
I think it would be great to add feedback that the rebase is indeed successful.
Also if you could summarize the changes so I could add an info to the release.

Question, what are all these "fix attr order" and "cleanup AF" ? are these meant to be squashed after ?

I may do a commit by commit diff review on monday.

@cladmi mentionned issues are CPP fixes because Murdock was complaining.
Regarding the tests, well all tests were run on hardware with sensors with the related PR. So It's not something easy to re-test.

Is there somewhere a summary of the actual API changes?

@kaspar030 You can have a look at #6577
Or you can search with github all PRs labelled I2C REWORK, then you will have the complete list of all merged PRs into the feature branch.

You can have a look at #6577
Or you can search with github all PRs labelled I2C REWORK, then you will have the complete list of all merged PRs into the feature branch.

@dylad I'm looking for an API change description. There was a PR / issue somewhere where the discussion took place, but I think it is not #6577.

@kaspar030 I think you're talking about #6576

I can open a wiki page for summarize all the changes adopted.

I can open a wiki page for summarize all the changes adopted.

That would be awesome!

@kaspar030 I'll inform you when this wiki page will be written. I'll start this weekend if I find some time.

@kaspar030 please see here this is the first round of the wiki page. I am not a good writer usually so don't hesitate to correct me or ask for more information.

not blocking this PR, but I just want to say that I'm against merging this PR in the current state, because of the suboptimal changes applied to the STM32F1 boards.

@dylad, for the wiki page, this PR also contains other changes, not directly related to the new API. These are the ones that come to my mind right now:

• all STMs CPUs provide I2C and the driver is unified (well, there's 2 versions of it)
• STM32F3 driver is fixed (it's broken in master)
• all STMs based boards use the new config style (array of structs), instead of defines
• previous point is also valid for sam0
• an I2C config was added to some nucleo/st disco boards provide (b-l475e-iot01a, nucleo-f722ze, nucleo-f070rb, and maybe others I forgot)
• nrf52xxdk I2C pin change to match Arduino pinout
• API change in some device drivers: lsm303dlhc, etc (I don't remember the complete list and it's difficult for me to get it on my phone)

I think #9574 should be handle before this one. Then I could rebase this branch on master.

@kaspar030 care to approve or dismiss your review as the release branch is in place for some time now. We have lot's of stuff waiting for this to be master.

Alright, let's go.

ACK and GO then!

Woooow! Congratulations to all the people involved! Special mention to @aabadie @dylad and @MrKevinWeiss. Thanks a lot guys!

Yes. Congrats to getting the biggest (I think) API-rework in RIOT ever merged!

Wow, it's finally over ! I'm so relief !
I'll announce the new on the mailing list today.

Congrats and thanks to everyone!