Skip to content

i2c: cpp check fixes#9574

Merged
cladmi merged 9 commits intoRIOT-OS:new_i2c_iffrom
dylad:fix_cpp_check
Jul 17, 2018
Merged

i2c: cpp check fixes#9574
cladmi merged 9 commits intoRIOT-OS:new_i2c_iffrom
dylad:fix_cpp_check

Conversation

@dylad
Copy link
Copy Markdown
Member

@dylad dylad commented Jul 14, 2018 •
edited
Loading

Contribution description

This PR should fix all CPP issues for new_i2c_if feature branch, I cherry-picked some commits from @smlng and #9571. I also include the required changes from @aabadie (see #9571 discussion)

Once this PR get merged, I'll rebase new_i2c_if3 to see if Murdock is happy.
This way it should ease comparison between original new_i2c_if branch and new_i2c_if3 which will be rebased onto master.

Issues/PRs references

#9571

@dylad dylad added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR TF: I2C Marks issues and PRs related to the work of the I²C rework task force labels Jul 14, 2018
@dylad
Copy link
Copy Markdown
Member Author

dylad commented Jul 14, 2018

Murdock still fails because ublox and EFM32 boards need to be rebased onto master but I prefer rebase a cloned branch rather than this branch to keep tracks of the changes.

@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Jul 15, 2018

Thanks @dylad, regarding STM32F1, this is ok now.

@vincent-d vincent-d mentioned this pull request Jul 16, 2018
Merged
@dylad dylad mentioned this pull request Jul 17, 2018
Merged
cladmi
cladmi reviewed Jul 17, 2018
View reviewed changes
boards/acd52832/include/periph_conf.h
.scl = 28,
.sda = 29
.sda = 29,
.speed = I2C_SPEED_NORMAL
Copy link
Copy Markdown
Contributor

@cladmi cladmi Jul 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you said, this one is actually more than a warning as I2C_SPEED_NORMAL is actually not 0. Thanks cpp check :)

@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented Jul 17, 2018

Murdock still fails because ublox and EFM32 boards need to be rebased onto master but I prefer rebase a cloned branch rather than this branch to keep tracks of the changes.

You mean that it is just Murdock that fails, and would fail without it anyway and that it can be merged even with the error ?

The changes look good to me.

@dylad
Copy link
Copy Markdown
Member Author

dylad commented Jul 17, 2018

This PR fixes a lot of issues with Murdock (all CPPcheck in fact) but with or without this PR, Murdock fails with EFM32 based board and the ublox board. Theses failures are not related to this PR.
And the remaining Murdock failures will be fix with the rebase.

@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented Jul 17, 2018

Ok that what I was thinking but was not sure.

@cladmi cladmi merged commit ffe66a7 into RIOT-OS:new_i2c_if Jul 17, 2018
@cladmi cladmi added this to the Release 2018.10 milestone Aug 11, 2018
@dylad dylad deleted the fix_cpp_check branch May 8, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cladmi cladmi cladmi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR TF: I2C Marks issues and PRs related to the work of the I²C rework task force

Projects

None yet

Milestone

Release 2018.10

Development

Successfully merging this pull request may close these issues.

4 participants

@dylad @aabadie @cladmi @smlng