gnrc/6lo: Set more data flag on all but last fragment#9471
gnrc/6lo: Set more data flag on all but last fragment#9471miri64 merged 2 commits intoRIOT-OS:masterfrom
Conversation
45ed8c0 to
3eb6ccc
Compare
|
With ContikiMAC (unpublished) this improves network latency significantly for fragmented unicast packets. |
|
The reassembly/fragmentation work did not start yet (see lacking replies to the mail you referenced). However, I'm currently refactoring 6Lo with the goal to get Fragmentation and IPHC more separated (see https://github.com/RIOT-OS/RIOT/projects/18 for progress). I don't think however, that that much collides with that effort and should be easily rebasable when it comes to conflicts. |
3eb6ccc to
13ce688
Compare
|
Can you please rebase. |
13ce688 to
938f74f
Compare
|
rebased |
miri64
left a comment
There was a problem hiding this comment.
Change looks good so far. I still want to test this though.
| #endif | ||
|
|
||
| /* Check weater to send the first or an Nth fragment */ | ||
| /* Check whether to send the first or an Nth fragment */ |
There was a problem hiding this comment.
Please put this spelling fix in a separate commit.
938f74f to
3cc0886
Compare
Spelling 😆 |
intentional ;) |
|
Okay 😀 |
miri64
left a comment
There was a problem hiding this comment.
ACK, fragmentation still works with various datagram sizes, and my sniff confirms that the "Frame pending" flag is now set for all fragments of a datagram, but the last.
Contribution description
Use the flag introduced in #9469 to signal to the link layer that more data will follow this packet on outgoing fragments, except for the final frag of the datagram.
Issues/PRs references
Depends on #9469
Does not do much difference without also merging #9470