Skip to content

gnrc_netif_ieee802154: Set FCF Frame Pending when more data is expected#9470

Merged
miri64 merged 2 commits intoRIOT-OS:masterfrom
jnohlgard:pr/netif-fcf-frame-pend
Aug 13, 2018
Merged

gnrc_netif_ieee802154: Set FCF Frame Pending when more data is expected#9470
miri64 merged 2 commits intoRIOT-OS:masterfrom
jnohlgard:pr/netif-fcf-frame-pend

Conversation

@jnohlgard
Copy link
Copy Markdown
Member

@jnohlgard jnohlgard commented Jun 30, 2018

Contribution description

Use the flag introduced in #9469 for setting the Frame Pending bit in the IEEE 802.15.4 Frame Control Field (FCF) when building the outgoing frame.

Issues/PRs references

Depends on #9469

@jnohlgard jnohlgard added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking State: waiting for other PR State: The PR requires another PR to be merged first GNRC CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 30, 2018
@jnohlgard jnohlgard added this to the Release 2018.07 milestone Jun 30, 2018
@jnohlgard jnohlgard requested a review from miri64 June 30, 2018 16:09
@jnohlgard jnohlgard mentioned this pull request Jun 30, 2018
Merged
@miri64
Copy link
Copy Markdown
Member

miri64 commented Jul 2, 2018

This might collide a little with the work @bergzand is currently doing in #9417. @gebart, since the dependency isn't merged yet, are you okay with merging this, after #9417, or are you able to work this in @bergzand?

@bergzand
Copy link
Copy Markdown
Member

bergzand commented Jul 2, 2018

Since #9417 needs a bit of work anyway, I was thinking of reworking this into #9417 as soon as this is merged. Probably requires the struct added in #9417 to be modified to contain a flags field which can hold these flags.

So, no, I don't mind having these merged first, I think I can work with this :)

@jnohlgard jnohlgard mentioned this pull request Jul 2, 2018
Closed
Joakim Nohlgård added 2 commits August 13, 2018 09:25
gnrc_netif: Introduce GNRC_NETIF_HDR_FLAGS_MORE_DATA
29e4a1b
gnrc_netif_ieee802154: set Frame Pending bit sometimes
a247d8b 
Set frame pending bit in IEEE 802.15.4 FCF when
GNRC_NETIF_HDR_FLAGS_MORE_DATA is set on the netif header on outbound
frames.
@jnohlgard jnohlgard force-pushed the pr/netif-fcf-frame-pend branch from d91c366 to a247d8b Compare August 13, 2018 07:27
@PeterKietzmann PeterKietzmann added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 13, 2018
@miri64 miri64 merged commit d852d90 into RIOT-OS:master Aug 13, 2018
@jnohlgard jnohlgard deleted the pr/netif-fcf-frame-pend branch August 14, 2018 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PeterKietzmann PeterKietzmann PeterKietzmann approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

Assignees

No one assigned

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2018.10

Development

Successfully merging this pull request may close these issues.

5 participants

@jnohlgard @miri64 @bergzand @PeterKietzmann @cladmi