gnrc_netif: Introduce GNRC_NETIF_HDR_FLAGS_MORE_DATA#9469
Merged
PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom Aug 13, 2018
Merged
gnrc_netif: Introduce GNRC_NETIF_HDR_FLAGS_MORE_DATA#9469PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom
PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom
Conversation
This was referenced Jun 30, 2018
Member
PeterKietzmann
left a comment
There was a problem hiding this comment.
Besides the minor comment I'm fine with introducing this flag
sys/include/net/gnrc/netif/hdr.h
Outdated
| /** | ||
| * @brief More data will follow | ||
| * | ||
| * This flag signals that this packet is part of a burst of packets. The link |
Member
There was a problem hiding this comment.
Comparing to the other flags above, shouldn't this go under @details?
Member
Author
There was a problem hiding this comment.
It's redundant, details is implicit when a new paragraph is started after the brief description.
Member
There was a problem hiding this comment.
Anyhow, for consistency reasons I would leave it in. Or remove the others, but that shouldn't be part of this PR I guess...
miri64
reviewed
Jul 2, 2018
sys/include/net/gnrc/netif/hdr.h
Outdated
| * cycled networks to tell the remote node to keep its radio turned on after | ||
| * receiving the first fragment. | ||
| * | ||
| * @see The corresponding bit in the IEEE 802.15.4 frame control field, @ref IEEE802154_FCF_FRAME_PEND |
fa05424 to
2cdc476
Compare
Member
Author
|
Addressed comments |
Member
|
Please squash |
2cdc476 to
29e4a1b
Compare
Member
Author
|
squashed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Introduce a flag that can be set in the gnrc_netif_hdr_t::flags, gnrc/netif/hdr.h.
The purpose is to use this flag for communicating between the upper layers when there is a burst of TX traffic expected. The first actual usage will be introduced in separate PRs as a part of 6lo fragmentation to set the IEEE 802.15.4 FCF frame pending bit on all but the last fragment.
Issues/PRs references