Skip to content

drivers/fxos8700: adapt to new i2c API#9268

Merged
jnohlgard merged 1 commit intoRIOT-OS:new_i2c_iffrom
jnohlgard:pr/i2c-fxos8700
Jun 29, 2018
Merged

drivers/fxos8700: adapt to new i2c API#9268
jnohlgard merged 1 commit intoRIOT-OS:new_i2c_iffrom
jnohlgard:pr/i2c-fxos8700

Conversation

@jnohlgard
Copy link
Copy Markdown
Member

@jnohlgard jnohlgard commented Jun 1, 2018

Contribution description

Adapt drivers/fxos8700 to new i2c API

Issues/PRs references

#6577

@jnohlgard jnohlgard added Area: drivers Area: Device drivers TF: I2C Marks issues and PRs related to the work of the I²C rework task force labels Jun 1, 2018
@jnohlgard jnohlgard changed the title fxos8700: Update to new i2c API drivers/fxos8700: adapt to new i2c API Jun 1, 2018
smlng
smlng previously requested changes Jun 28, 2018
* @name Accelerometer+magnetometer configuration
* @{
*/
#define FXOS8700_PARAM_ADDR 0x1f
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please put parentheses around this

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really something that is worth blocking a PR for?
I will remove this change to avoid merge problems with master later on (#9442)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah sorry

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@smlng smlng dismissed their stale review June 28, 2018 18:52

invalid

Copy link
Copy Markdown
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jnohlgard
Copy link
Copy Markdown
Member Author

I will remove the board.h commit before merging, it is already merged in master

@jnohlgard jnohlgard merged commit e4dd788 into RIOT-OS:new_i2c_if Jun 29, 2018
@jnohlgard jnohlgard deleted the pr/i2c-fxos8700 branch June 29, 2018 06:56
basilfx pushed a commit to basilfx/RIOT that referenced this pull request Jul 10, 2018
drivers/fxos8700: adapt to new i2c API
dylad pushed a commit to dylad/RIOT that referenced this pull request Jul 10, 2018
drivers/fxos8700: adapt to new i2c API
dylad pushed a commit that referenced this pull request Jul 11, 2018
drivers/fxos8700: adapt to new i2c API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: drivers Area: Device drivers TF: I2C Marks issues and PRs related to the work of the I²C rework task force

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants