Skip to content

boards/frdm: Add bus configuration for onboard FXOS8700CQ sensor #9442

Merged
dylad merged 3 commits intoRIOT-OS:masterfrom
jnohlgard:pr/fxos8700-frdm
Jun 27, 2018
Merged

boards/frdm: Add bus configuration for onboard FXOS8700CQ sensor #9442
dylad merged 3 commits intoRIOT-OS:masterfrom
jnohlgard:pr/fxos8700-frdm

Conversation

@jnohlgard
Copy link
Copy Markdown
Member

@jnohlgard jnohlgard commented Jun 27, 2018 •
edited
Loading

Contribution description

Adds missing bus and slave address configuration for the supported FRDM Kinetis boards. These boards each have different configurations for the FXOS8700 sensor, so it is necessary to specify the address for each board.
This should not be affected by the i2c embargo because it applies to the device driver configuration and it works exactly the same both in master and after the changes in #9268.

Issues/PRs references

#9268

@jnohlgard jnohlgard added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: boards Area: Board ports labels Jun 27, 2018
@jnohlgard jnohlgard added this to the Release 2018.07 milestone Jun 27, 2018
@jnohlgard jnohlgard requested a review from dylad June 27, 2018 19:47
@jnohlgard
Copy link
Copy Markdown
Member Author

jnohlgard commented Jun 27, 2018

tested on frdm-kw41z

dylad
dylad approved these changes Jun 27, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@dylad dylad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested-ACK
This look good, users don't have to modify the fxos8700_params.h anymore if they want to use these boards.
If it's not harmful to my beloved I2C refactoring we can merge this :)

@dylad dylad merged commit ea7044f into RIOT-OS:master Jun 27, 2018
@jnohlgard jnohlgard mentioned this pull request Jun 28, 2018
Merged
@jnohlgard jnohlgard deleted the pr/fxos8700-frdm branch September 24, 2018 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dylad dylad dylad approved these changes

Assignees

No one assigned

Labels

Area: boards Area: Board ports Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2018.07

Development

Successfully merging this pull request may close these issues.

2 participants

@jnohlgard @dylad