Return-based error-handling for shell handlers#2602
Conversation
examples/rpl_udp/helper.c
Outdated
There was a problem hiding this comment.
redundant check for number of arguments, already checked on L132
|
Needs rebase. It also reverts |
|
(I made an error in the previous comment: I meant #2581) |
|
@authmillenon For your second last comment - are the one's I was a little concerned about for the two patches I am not supposed to change them or do I have to resubmit the patch ? Can you explain what exactly is meant by reverting #2581 , does that mean I resolved the merge conflicts while rebasing incorrectly previously ? |
Just try it and compile
I think you must not concern yourself with this one. It's a normal UNIX process main (for the native process), so changing them might be harmful to the native port.
Obviously, your changes apply to the version of the commands before this. #2581 reduced the shell handlers for |
a76170d to
900bc9e
Compare
|
I tried compiling |
|
@thomaseichinger do you know what this is about? |
900bc9e to
95742fb
Compare
|
|
95742fb to
f7baf08
Compare
examples/rpl_udp/helper.c
Outdated
There was a problem hiding this comment.
Don't get the point of this change, nor how it is related to return based error-handling.
There was a problem hiding this comment.
(Moreover: the a is set in https://github.com/RIOT-OS/RIOT/pull/2602/files#diff-774299209354f6ffeb33ebb74a48b5c9R144 already).
|
Apart from #2602 (comment) and #2602 (comment) I'm fine with this PR |
f7baf08 to
33e7440
Compare
|
@authmillenon : Made the changes you suggested in my latest commit. |
|
For the future: please don't squash your changes immediately so it's easier for me to see your updates. |
|
(moreover, travis is already kindof overheated, so I prefer if I can stop the build of out-dated commits ;-), which I can't if you overwrite them) |
|
Apart from that: ACK, when Travis is happy. Please squash (yes, you can overwrite my old commit with your's ;-)) |
33e7440 to
1be707d
Compare
- Included the missing parts. - Squashed with @authmillenon's commit
1be707d to
9aae656
Compare
|
Done squashing . Thanks for letting me use your commit :) ( Now let's see how long Travis takes :P ) |
|
Kindly restart the build for this one :) |
|
I did already for a hundredth time ^^. There are either reachability issues with github or one of the apt-repositories. I'll keep the tab open :-) |
|
And go. |
Return-based error-handling for shell handlers
|
@kushalsingh007 congratz for this one ;-) |
|
😃 Thanks |
-Updated version of branch used by @authmillenon ( continuation of his work )
-Removed whitespace errors
-Part of fix for #708