shell: port ifconfig for ng_netif#2581
Merged
miri64 merged 2 commits intoRIOT-OS:masterfrom Mar 17, 2015
Merged
Conversation
428547a to
0058ddb
Compare
This was referenced Mar 11, 2015
90ac0cb to
9d7e6ec
Compare
Member
Author
|
Rebased to master |
21a05b1 to
020d695
Compare
Member
Author
|
Rebased to master |
020d695 to
dd61cd3
Compare
Member
Author
|
Rebased to current master and changed dependecies for netif a little (reasoning: see 5425cc2). |
Makefile.dep
Outdated
Contributor
There was a problem hiding this comment.
How about adding 'ng_netreg' here as well? Although it's not directly needed for the shell commands, it is used by all other link-layer modules (drivers, MAC layers)
Though they are not needed in the code of `ng_netif` both `ng_pktbuf` and `ng_netapi` are needed to use `ng_netif` in a sensible way.
1cba85c to
d6262df
Compare
Member
Author
|
addressed comments and squashed in hopes to get a fast ACK |
Contributor
|
looks good to me -> ACK once Travis is happy. |
Member
Author
|
And go... (finally) |
miri64
added a commit
that referenced
this pull request
Mar 17, 2015
shell: port ifconfig for ng_netif
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2580(merged). Will port IPv6 support as follow-up to #2437 (see #2582).This merges the functionality of #2525 with this of the original
ifconfigcommand