Skip to content

tests/periph_adc: added test for adc driver#1951

Merged
haukepetersen merged 1 commit intoRIOT-OS:masterfrom
haukepetersen:add_test_periphadc
Nov 6, 2014
Merged

tests/periph_adc: added test for adc driver#1951
haukepetersen merged 1 commit intoRIOT-OS:masterfrom
haukepetersen:add_test_periphadc

Conversation

@haukepetersen
Copy link
Copy Markdown
Contributor

@haukepetersen haukepetersen commented Nov 6, 2014

No description provided.

@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Nov 6, 2014

Tested with stm32f4discovery. Worked fine! stm32f0discovery does not provide periph_spi in the Makefile.features. Shurely Travis will tell you the same. Maybe you can add this?

PeterKietzmann
PeterKietzmann reviewed Nov 6, 2014
View reviewed changes
tests/periph_adc/main.c Outdated
Copy link
Copy Markdown
Member

@PeterKietzmann PeterKietzmann Nov 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be ADC_MAX_CHANNELS ?

Copy link
Copy Markdown
Member

@PeterKietzmann PeterKietzmann Nov 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... in line 63 ...

Copy link
Copy Markdown
Contributor Author

@haukepetersen haukepetersen Nov 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, youre right. Copy and paste failure...

@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Nov 6, 2014

Ok Travis was happy, hm.. For some reason the loop just iterates once on the stm32f0discovery board, after changing the above comments. Also LED PC9 blinks continuously.

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Nov 6, 2014

fixed channel define as pointed out by @PeterKietzmann

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Nov 6, 2014

@PeterKietzmann the problem with the stm32f0 looks like it has to do something with the vtimer, could be connected to #1519

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Nov 6, 2014

and for the missing ADC feature please see (and review) #1955

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Nov 6, 2014

@PeterKietzmann I also found the problem with the vtimer that made the ADC test fail, see #1956

@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Nov 6, 2014

#1956 fixed the problems on stm32f0discovery

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Nov 6, 2014

so can we merge this test?

@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Nov 6, 2014

Si senor, the test is fine. ACK

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Nov 6, 2014

and go.

haukepetersen added a commit that referenced this pull request Nov 6, 2014
@haukepetersen
Merge pull request #1951 from haukepetersen/add_test_periphadc
b501eb8 
tests/periph_adc: added test for adc driver
@haukepetersen haukepetersen merged commit b501eb8 into RIOT-OS:master Nov 6, 2014
@haukepetersen haukepetersen deleted the add_test_periphadc branch November 6, 2014 15:44
@PeterKietzmann PeterKietzmann mentioned this pull request Nov 6, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@haukepetersen @PeterKietzmann