usbus/msc: fixes for synopsys dwc2 driver#19455
Merged
bors[bot] merged 2 commits intoRIOT-OS:masterfrom Apr 6, 2023
Merged
Conversation
This function should not be called by the driver as USBUS will handle it already. So remove this call to prevent duplication Signed-off-by: Dylan Laduranty <dylan.laduranty@mesotic.com>
Signed-off-by: Dylan Laduranty <dylan.laduranty@mesotic.com>
gschorcht
reviewed
Apr 6, 2023
Contributor
gschorcht
left a comment
There was a problem hiding this comment.
Works now with usbdev_synopsys_dwc2 and FS PHY.
gschorcht
approved these changes
Apr 6, 2023
Contributor
|
bors merge |
Contributor
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Apr 15, 2023
19456: usbus/msc: fixes for synopsys dwc2 [backport 2023.04] r=dylad a=dylad ### Contribution description This is a backport PR containing two fixes for USBUS MSC driver so it can works with `usbdev_synopsys_dwc2` driver See #19455 for more context. ### Testing procedure Same as #19455 ### Issues/PRs references See #19455 Co-authored-by: Dylan Laduranty <dylan.laduranty@mesotic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR provides two fixes for USBUS MSC driver.
9e88db7 removes a call to
usbdev_control_slicer_ready()as this function is called by USBUS stack right after so remove this call to avoid duplication.608d49c moves the call to
usbdev_ep_xmit(), which prepares the bulk MSC OUT endpoint to receives data, from the_init()function toUSB_MSC_SETUP_REQ_GMLcontrol request. The issue was that this endpoint was prepare to early and an USB reset might reset this setting. (This is the case for theusbdev_synopsys_dwc2driver) Thus the endpoint is not ready to receive data when the host send it.Testing procedure
Test this PR with
tests/usbus_mscon any board using theusbdev_synopsys_dwc2driver with a FS PHYThere is another issue with HS PHY that should be fix too.
Issues/PRs references
None.