Skip to content

usbus/msc: fixes for synopsys dwc2 [backport 2023.04]#19456

Merged
bors[bot] merged 2 commits intoRIOT-OS:2023.04-branchfrom
dylad:backport/usbus/msc/fixes_for_synopsys_dwc2
Apr 15, 2023
Merged

usbus/msc: fixes for synopsys dwc2 [backport 2023.04]#19456
bors[bot] merged 2 commits intoRIOT-OS:2023.04-branchfrom
dylad:backport/usbus/msc/fixes_for_synopsys_dwc2

Conversation

@dylad
Copy link
Copy Markdown
Member

@dylad dylad commented Apr 6, 2023

Contribution description

This is a backport PR containing two fixes for USBUS MSC driver so it can works with usbdev_synopsys_dwc2 driver
See #19455 for more context.

Testing procedure

Same as #19455

Issues/PRs references

See #19455

dylad added 2 commits April 6, 2023 09:35
@dylad
usbus/msc: remove call to usbdev_control_slicer_ready()
ba13c51 
This function should not be called by the driver as USBUS will handle it already. So remove this call to prevent duplication

Signed-off-by: Dylan Laduranty <dylan.laduranty@mesotic.com>
@dylad
usbus/msc: ready MSC bulk OUT endpoint in USB_MSC_SETUP_REQ_GML request
f5e5baa 
Signed-off-by: Dylan Laduranty <dylan.laduranty@mesotic.com>
@dylad dylad added the Process: release backport Integration Process: The PR is a release backport of a change previously provided to master label Apr 6, 2023
@dylad dylad requested review from aabadie and bergzand as code owners April 6, 2023 07:37
@github-actions github-actions bot added Area: sys Area: System Area: USB Area: Universal Serial Bus labels Apr 6, 2023
@gschorcht gschorcht added the Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) label Apr 11, 2023
@MrKevinWeiss MrKevinWeiss added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 14, 2023
MrKevinWeiss
MrKevinWeiss approved these changes Apr 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backport ACK

@MrKevinWeiss
Copy link
Copy Markdown
Contributor

MrKevinWeiss commented Apr 14, 2023

bors merge

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Apr 14, 2023

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@riot-ci
Copy link
Copy Markdown

riot-ci commented Apr 14, 2023 •
edited
Loading

Murdock results

✔️ PASSED

f5e5baa usbus/msc: ready MSC bulk OUT endpoint in USB_MSC_SETUP_REQ_GML request

Success Failures Total Runtime
6882 0 6882 09m:43s

Artifacts

@dylad
Copy link
Copy Markdown
Member Author

dylad commented Apr 15, 2023

bors cancel
bors merge

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Apr 15, 2023

Build succeeded:

@bors bors bot merged commit 1400587 into RIOT-OS:2023.04-branch Apr 15, 2023
@dylad dylad deleted the backport/usbus/msc/fixes_for_synopsys_dwc2 branch April 15, 2023 09:44
@jia200x jia200x added this to the Release 2023.04 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrKevinWeiss MrKevinWeiss MrKevinWeiss approved these changes

@bergzand bergzand Awaiting requested review from bergzand bergzand is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

Assignees

No one assigned

Labels

Area: sys Area: System Area: USB Area: Universal Serial Bus CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2023.04

Development

Successfully merging this pull request may close these issues.

5 participants

@dylad @MrKevinWeiss @riot-ci @jia200x @gschorcht