drivers: model kconfig for Ethernet drivers#17739
Merged
MrKevinWeiss merged 12 commits intoRIOT-OS:masterfrom Jul 25, 2022
Merged
drivers: model kconfig for Ethernet drivers#17739MrKevinWeiss merged 12 commits intoRIOT-OS:masterfrom
MrKevinWeiss merged 12 commits intoRIOT-OS:masterfrom
Conversation
This was referenced Mar 4, 2022
Contributor
|
Hmm seems to be some xtimer/ztimer issues... |
d587b1c to
3d8b979
Compare
Contributor
Author
It was my fault, poor rebasing. Let's see now |
Contributor
Author
|
Seems to work |
Contributor
|
Any blockers? This only touches kconfig so it should be fine if it green. @maribu ? |
3d8b979 to
d4233e5
Compare
MrKevinWeiss
approved these changes
Jul 25, 2022
Contributor
MrKevinWeiss
left a comment
There was a problem hiding this comment.
Looks good from the coding side. Lets see what murdock says then please remove the limiting build commit. ACK.
d4233e5 to
5b3936d
Compare
5b3936d to
1716638
Compare
Contributor
Author
|
Fixed whitespace issue |
Contributor
|
Finally eh? |
This was referenced Aug 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This models all Ethernet drivers in Kconfig. To test this (and also to make tests stack-independent) all related test applications are modified to run only using netdev (note that to test with GNRC we still have
tests/driver_netdev_common). Additionally, specific test applications forstm32_ethandesp_ethare added.Note: For now this includes some extra changes (e.g., 4b30314, fd9466b, 8da03c2) that most likely will be split.Testing procedure
Issues/PRs references
#17744
#17745
#17746
#17747