Skip to content

cpu/sam0_common/eth: expose correct setup function#17746

Merged
dylad merged 1 commit intoRIOT-OS:masterfrom
leandrolanzieri:cpu/sam0_common/eth/expose_correct_setup
Mar 7, 2022
Merged

cpu/sam0_common/eth: expose correct setup function#17746
dylad merged 1 commit intoRIOT-OS:masterfrom
leandrolanzieri:cpu/sam0_common/eth/expose_correct_setup

Conversation

@leandrolanzieri
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri commented Mar 4, 2022

Contribution description

Currently sam0_eth_netdev.h exposes sam0_eth_netdev_setup, which is not defined. Instead sam0_eth_setup is used, but not exposed. This fixes the issue by changing the exposed setup function.

Testing procedure

  • Green CI
  • Alternatively run a networking example on a board sam0-based board with Ethernet (e.g., same54-xpro).

Issues/PRs references

Split from #17739

@leandrolanzieri leandrolanzieri added the Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) label Mar 4, 2022
@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Area: network Area: Networking Area: sys Area: System Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Mar 4, 2022
@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 4, 2022
@dylad dylad added this to the Release 2022.04 milestone Mar 4, 2022
@fjmolinas fjmolinas mentioned this pull request Mar 4, 2022
Merged
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 4, 2022
@dylad dylad enabled auto-merge March 4, 2022 19:52
@dylad dylad added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 5, 2022
@leandrolanzieri leandrolanzieri added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 7, 2022
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 7, 2022
@dylad dylad merged commit 9d459b8 into RIOT-OS:master Mar 7, 2022
@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Mar 7, 2022

Thanks for reviewing!

@leandrolanzieri leandrolanzieri deleted the cpu/sam0_common/eth/expose_correct_setup branch March 7, 2022 17:59
@leandrolanzieri leandrolanzieri mentioned this pull request Mar 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benpicco benpicco benpicco approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann

@cgundogan cgundogan Awaiting requested review from cgundogan

@dylad dylad Awaiting requested review from dylad dylad is a code owner

@keestux keestux Awaiting requested review from keestux keestux is a code owner

Assignees

No one assigned

Labels

Area: cpu Area: CPU/MCU ports Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2022.04

Development

Successfully merging this pull request may close these issues.

3 participants

@leandrolanzieri @benpicco @dylad