Skip to content

drivers/encx24j600: define default parameters#17747

Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom
leandrolanzieri:drivers/encx24j600/default_params
Mar 5, 2022
Merged

drivers/encx24j600: define default parameters#17747
benpicco merged 1 commit intoRIOT-OS:masterfrom
leandrolanzieri:drivers/encx24j600/default_params

Conversation

@leandrolanzieri
Copy link
Copy Markdown
Contributor

Contribution description

This adds default params to the encx24j600 (the values are taken from the test application), and modifies the auto_init code to support multiple driver instances.

Testing procedure

  • Green CI
  • Optionally run the test application (I could not do this as I don't have the device)

Issues/PRs references

Split from #17739

@github-actions github-actions bot added Area: drivers Area: Device drivers Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework labels Mar 4, 2022
@leandrolanzieri leandrolanzieri added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label Mar 4, 2022
@github-actions github-actions bot added the Area: tools Area: Supplementary tools label Mar 4, 2022
Copy link
Copy Markdown
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the doc issues are sorted and murdock is happy I ACK!

@MrKevinWeiss
Copy link
Copy Markdown
Contributor

Please squash

@leandrolanzieri leandrolanzieri force-pushed the drivers/encx24j600/default_params branch from 5b6ab25 to de79edb Compare March 4, 2022 08:58
@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 4, 2022
@fjmolinas fjmolinas added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 4, 2022
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 4, 2022
@benpicco benpicco merged commit f31fdfd into RIOT-OS:master Mar 5, 2022
@OlegHahm OlegHahm added this to the Release 2022.04 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: drivers Area: Device drivers Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants