Skip to content

net: Initial import of a packet wrapper for priority_queue#1640

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64:packetqueue
Oct 10, 2014
Merged

net: Initial import of a packet wrapper for priority_queue#1640
miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64:packetqueue

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Sep 5, 2014

Depends on #1639

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 17, 2014

Rebased to current master.

@miri64 miri64 assigned OlegHahm and unassigned Kijewski Sep 17, 2014
@Kijewski
Copy link
Copy Markdown
Contributor

I don't quite see the need for pktqueue, it's just a priority_queue in disguise.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 18, 2014

Disguise as in: it adds not more code to the memory but makes the code that uses it easier to read?

@LudwigKnuepfer
Copy link
Copy Markdown
Member

How does it achieve that?

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 18, 2014

It's a collection of inline functions (no additional code) and it does all the required casting for you (interfacing code is easier to read)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As usual: I prefer parens.

Edit: Or why not simply Q_LEN. Much easier to read.

@OlegHahm
Copy link
Copy Markdown
Member

@Kijewski, do you consider this as a problem? From my side, I would give it an ACK.

@OlegHahm OlegHahm assigned Kijewski and unassigned OlegHahm Oct 10, 2014
@Kijewski
Copy link
Copy Markdown
Contributor

I am not opposed to this code, I just don't see much merit.
But if @authmillenon finds it easier to use these wrapper functions for her use case, then ACK.

@OlegHahm
Copy link
Copy Markdown
Member

@authmillenon, merge at will.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Oct 10, 2014

Addressed @OlegHahm's comment and go

miri64 added a commit that referenced this pull request Oct 10, 2014
net: Initial import of a packet wrapper for priority_queue
@miri64 miri64 merged commit 36f8e3c into RIOT-OS:master Oct 10, 2014
@miri64 miri64 deleted the packetqueue branch October 10, 2014 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: network Area: Networking Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants