core: priority_queue: simplify inheritance#1639
Merged
LudwigKnuepfer merged 1 commit intoRIOT-OS:masterfrom Sep 10, 2014
Merged
core: priority_queue: simplify inheritance#1639LudwigKnuepfer merged 1 commit intoRIOT-OS:masterfrom
LudwigKnuepfer merged 1 commit intoRIOT-OS:masterfrom
Conversation
Contributor
|
Maybe you could try to remove the member |
Member
Author
|
For this I have to understand the magic you did there ;-) |
Member
Author
|
For now I prefer this small patch. |
Contributor
|
OK, ACK. |
Member
|
Is it possible that this breaks the vtimer? If I remember right, it already "extends" |
Contributor
|
No, vtimer_t just uses it as a proper member. |
Contributor
|
This line should be priority_queue_add(&longterm_priority_queue_root, &timer->priority_queue_entry);Likewise in all the other instances. |
Member
|
WTF. Will you create a PR for this? |
Contributor
|
I will, tomorrow. :) |
Member
Author
|
Nevertheless, this one needs a second ACK |
Member
|
ACK |
LudwigKnuepfer
pushed a commit
that referenced
this pull request
Sep 10, 2014
core: priority_queue: simplify inheritance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
datais last, it can get as big as someone who wants to extend the priority queue likes to.