cpu/board: updated spi driver for arduino-due by PeterKietzmann · Pull Request #1584 · RIOT-OS/RIOT

PeterKietzmann · 2014-08-19T14:27:11Z

This PR should replace PR #1544 from @blanloem because his internship ended. It contains an updated and adapted version of the SPI low-level driver for arduino-due boards.

mehlis · 2014-09-13T13:20:46Z

@PeterKietzmann please rebase your code

mehlis · 2014-10-03T14:58:10Z

I think this PR should be spitted in two, that the spi_test is independent... and then the test can more in RIOT separately. @haukepetersen what do you think?

mehlis · 2014-10-03T15:10:39Z

@PeterKietzmann this drivers does not implement

spi_transfer_reg
spi_transfer_regs

which are necessary for your nrf24l01 driver: #1704

you can probably copy https://github.com/RIOT-OS/RIOT/blob/master/cpu/stm32f1/periph/spi.c#L185

or am I wrong with that?

mehlis · 2014-10-03T15:59:10Z

just for the record

PeterKietzmann · 2014-10-06T07:07:47Z

Implemented spi_transfer_reg and spi_transfer_regs. Deleted tests/test_spi (cause there is tests/periph_spi in master now). Rebased.

PeterKietzmann · 2014-10-06T13:33:12Z

Would like to see this in the master soon, especially because PR #1704 needs it. For me it is fine! Someone check, ACK?

LudwigKnuepfer · 2014-10-06T14:04:27Z

ACK for functionality

LudwigKnuepfer · 2014-10-06T14:05:31Z

cpu/sam3x8e/periph/spi.c

please remove this (and possibly other prefixing) blank line(s)

PeterKietzmann · 2014-10-06T15:07:15Z

addressed some style fixes, travis warnings and squashed

LudwigKnuepfer · 2014-10-06T15:21:56Z

Please change the commit message. As far as I see, the commit does not complete, but rather implement SPI for the sam.. right?

LudwigKnuepfer · 2014-10-06T15:37:03Z

Kicked Travis

LudwigKnuepfer · 2014-10-06T15:54:21Z

Travis is having a bad day.

LudwigKnuepfer · 2014-10-06T16:02:01Z

cpu/sam3x8e/periph/spi.c

LudwigKnuepfer · 2014-10-06T16:13:34Z

cpu/sam3x8e/periph/spi.c

missing default: ?

BTW: I think a lot of these switch statements miss a default case.

LudwigKnuepfer · 2014-10-06T16:24:12Z

Please check the periph API for all functions to make sure the return values and parameters match the specification.

PeterKietzmann · 2014-10-07T08:17:01Z

Travis is happy now. And you @LudwigOrtmann, @haukepetersen ?

LudwigKnuepfer · 2014-10-07T08:24:41Z

My happiness would be easier to determine if you had not squashed immediately (as suggested by the development procedures) ;-)

LudwigKnuepfer · 2014-10-07T08:25:15Z

#1584 (comment) has not been addressed yet.

LudwigKnuepfer · 2014-10-07T08:27:51Z

boards/arduino-due/include/periph_conf.h

trailing whitespace

PeterKietzmann · 2014-10-07T08:43:40Z

To be honest I do not really know what you mean with "arduino-changes".
Do you mean changes in boards/arduino-due/periph_conf.h and
cpu/sam3x8e/periph/spi.c?

LudwigKnuepfer · 2014-10-07T08:46:16Z

I mean the changes in boards/arduino-due/periph_conf.h.

LudwigKnuepfer · 2014-10-07T08:52:12Z

I'm happy otherwise.

LudwigKnuepfer · 2014-10-07T09:13:42Z

cpu/sam3x8e/periph/spi.c

I don't think casting is the right approach here.
I mean - if length really exceeds int, the result is off now, and this is lost.
IFF this should be handled at all, I'd length = (length > INT_MAX) INT_MAX : length; (if INT_MAX is the right macro, this is off the top of my head).

Then I would suggest to leave it like before without a cast and change it if we found a good solution in PR #1769.

PeterKietzmann · 2014-10-08T11:34:09Z

Everyone happy? @LudwigOrtmann, @haukepetersen ?

LudwigKnuepfer · 2014-10-08T11:46:48Z

Happy Happy!

ACK

cpu/board: updated spi driver for arduino-due

BytesGalore added WIP labels Aug 19, 2014

PeterKietzmann mentioned this pull request Aug 28, 2014

Arduino due spi drivers #1544

Closed

OlegHahm assigned haukepetersen Sep 11, 2014

PeterKietzmann force-pushed the add_sam3x_spi branch 2 times, most recently from f93bfbd to 711a967 Compare September 15, 2014 07:15

PeterKietzmann removed the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Sep 24, 2014

PeterKietzmann force-pushed the add_sam3x_spi branch from b792e81 to db5a7c9 Compare October 6, 2014 06:52

PeterKietzmann mentioned this pull request Oct 6, 2014

drivers/nrf24l01+ : added low-level functions for nrf24l01+ transceiver #1704

Merged

LudwigKnuepfer added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Oct 6, 2014

LudwigKnuepfer reviewed Oct 6, 2014
View reviewed changes

cpu/sam3x8e/periph/spi.c Outdated

Copy link
Copy Markdown

Member

LudwigKnuepfer Oct 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this (and possibly other prefixing) blank line(s)

PeterKietzmann force-pushed the add_sam3x_spi branch 4 times, most recently from 26feedb to e02d13e Compare October 6, 2014 15:05

LudwigKnuepfer removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Oct 6, 2014

LudwigKnuepfer reviewed Oct 6, 2014
View reviewed changes

cpu/sam3x8e/periph/spi.c Outdated

Copy link
Copy Markdown

Member

LudwigKnuepfer Oct 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

divider

LudwigKnuepfer reviewed Oct 6, 2014
View reviewed changes

PeterKietzmann force-pushed the add_sam3x_spi branch from a444c37 to 47114fb Compare October 7, 2014 07:33

LudwigKnuepfer reviewed Oct 7, 2014
View reviewed changes

boards/arduino-due/include/periph_conf.h Outdated

Copy link
Copy Markdown

Member

LudwigKnuepfer Oct 7, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing whitespace

LudwigKnuepfer reviewed Oct 7, 2014
View reviewed changes

PeterKietzmann mentioned this pull request Oct 7, 2014

driver - periph: Extend SPI low-level driver interface #1770

Merged

PeterKietzmann force-pushed the add_sam3x_spi branch from aa1e6e4 to 218ad47 Compare October 8, 2014 07:24

PeterKietzmann added 2 commits October 8, 2014 12:20

cpu: Implement SPI driver for sam3x8e

502ceaf

boards: Implement SPI definitions for arduino-due

695c34a

PeterKietzmann force-pushed the add_sam3x_spi branch from 218ad47 to 695c34a Compare October 8, 2014 10:21

LudwigKnuepfer assigned LudwigKnuepfer and unassigned haukepetersen Oct 8, 2014

LudwigKnuepfer pushed a commit that referenced this pull request Oct 8, 2014

Merge pull request #1584 from PeterKietzmann/add_sam3x_spi

b879f78

cpu/board: updated spi driver for arduino-due

LudwigKnuepfer merged commit b879f78 into RIOT-OS:master Oct 8, 2014

PeterKietzmann deleted the add_sam3x_spi branch March 26, 2015 08:47

Conversation

PeterKietzmann commented Aug 19, 2014

Uh oh!

mehlis commented Sep 13, 2014

Uh oh!

mehlis commented Oct 3, 2014

Uh oh!

mehlis commented Oct 3, 2014

Uh oh!

mehlis commented Oct 3, 2014

Uh oh!

PeterKietzmann commented Oct 6, 2014

Uh oh!

PeterKietzmann commented Oct 6, 2014

Uh oh!

LudwigKnuepfer commented Oct 6, 2014

Uh oh!

LudwigKnuepfer Oct 6, 2014

Choose a reason for hiding this comment

Uh oh!

PeterKietzmann commented Oct 6, 2014

Uh oh!

LudwigKnuepfer commented Oct 6, 2014

Uh oh!

LudwigKnuepfer commented Oct 6, 2014

Uh oh!

LudwigKnuepfer commented Oct 6, 2014

Uh oh!

LudwigKnuepfer Oct 6, 2014

Choose a reason for hiding this comment

Uh oh!

LudwigKnuepfer Oct 6, 2014

Choose a reason for hiding this comment

Uh oh!

LudwigKnuepfer Oct 6, 2014

Choose a reason for hiding this comment

Uh oh!

LudwigKnuepfer commented Oct 6, 2014

Uh oh!

PeterKietzmann commented Oct 7, 2014

Uh oh!

LudwigKnuepfer commented Oct 7, 2014

Uh oh!

LudwigKnuepfer commented Oct 7, 2014

Uh oh!

LudwigKnuepfer Oct 7, 2014

Choose a reason for hiding this comment

Uh oh!

PeterKietzmann commented Oct 7, 2014

Uh oh!

LudwigKnuepfer commented Oct 7, 2014

Uh oh!

LudwigKnuepfer commented Oct 7, 2014

Uh oh!

LudwigKnuepfer Oct 7, 2014

Choose a reason for hiding this comment

Uh oh!

PeterKietzmann Oct 7, 2014

Choose a reason for hiding this comment

Uh oh!

PeterKietzmann commented Oct 8, 2014

Uh oh!

LudwigKnuepfer commented Oct 8, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants