Conversation
There was a problem hiding this comment.
parens, here and in the other lines
|
nice, congrats to your first PR |
tests/test_spi/main.c
Outdated
There was a problem hiding this comment.
comment style (although this is more a case of remove or not)
There was a problem hiding this comment.
You can just though out the SPI_1... defines for now.
|
Could you also update the |
cpu/sam3x8e/periph/spi.c
Outdated
There was a problem hiding this comment.
You need to guard the file with
#if SPI_NUMOF
and the corresponding #endif in the end of the file. Otherwise boards that use this CPU would try to compile this file even if they don't have an SPI device defined which will then end up in missing types etc.
This should also take care of the failed Travis tests for the Udoo board.
There was a problem hiding this comment.
Hi,
I am studing at Grenoble where INRIA has some labs but I am currently doing an internship at HAW for two months.
There was a problem hiding this comment.
Please use RIOTs standard license header.
This file is subject to the terms and conditions of the GNU Lesser
General Public License v2.1. See the file LICENSE in the top level
directory for more details.
|
Is it still WIP? |
This PR provides SPI drivers for the Arduino-Due board and a project that tests these drivers.