fix(sdk-python): standardize TAG_PREFIX to include v suffix#3832
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes the Python SDK release helper’s tag prefix to include the v (changing sdk-python- → sdk-python-v) to match the TypeScript SDK convention, while keeping the resulting git/GitHub release tag names unchanged (sdk-python-v<version>).
Changes:
- Update
TAG_PREFIXtosdk-python-v. - Remove manual
vinjection at the call site by passingreleaseVersioninstead of a pre-composedreleaseTaginto the internal release-state check. - Adjust log messages and tag composition to consistently use
${TAG_PREFIX}${releaseVersion}.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
wenshao
previously approved these changes
May 5, 2026
wenshao
left a comment
Collaborator
There was a problem hiding this comment.
No issues found. LGTM! ✅ — deepseek-v4-pro via Qwen Code /review
f89fb70 to
8ff0ccb
Compare
wenshao
reviewed
May 5, 2026
Align the Python SDK's TAG_PREFIX with the TypeScript SDK convention by changing it from 'sdk-python-' to 'sdk-python-v'. This removes the need for callers to manually inject the `v` when composing git tags, eliminating an asymmetry that could lead to doubled or missing `v` prefixes when code is copied between SDK release helpers. The final tag format (sdk-python-v0.1.0) is unchanged. Closes #3793 🤖 Generated with [Qwen Code](https://github.com/QwenLM/qwen-code)
8ff0ccb to
1bf3ead
Compare
wenshao
approved these changes
May 5, 2026
wenshao
left a comment
Collaborator
There was a problem hiding this comment.
No issues found. LGTM! ✅ — gpt-5.5 via Qwen Code /review
TaimoorSiddiquiOfficial
pushed a commit
to TaimoorSiddiquiOfficial/HopCode
that referenced
this pull request
May 6, 2026
…nLM#3836) - fix(core): prevent auto-memory recall from blocking main request (QwenLM#3814) - feat(core,cli): surface and cancel auto-memory dream tasks (QwenLM#3836) - fix(sdk-python): standardize TAG_PREFIX to include v suffix (QwenLM#3832) Conflict resolutions: - Footer.tsx: removed stale dreamRunning/configInitMessage (not used in render) - BackgroundTaskViewContext.tsx: kept @hoptrendy/hopcode-core, added createDebugLogger - manager.test.ts: included upstream cancelTask + subscribe filter tests, replaced QWEN_CODE_MEMORY_LOCAL with HOPCODE_MEMORY_LOCAL - get-release-version.js: kept hopcode-sdk brand, adopted upstream v prefix fix Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
DragonnZhang
pushed a commit
that referenced
this pull request
May 8, 2026
Align the Python SDK's TAG_PREFIX with the TypeScript SDK convention by changing it from 'sdk-python-' to 'sdk-python-v'. This removes the need for callers to manually inject the `v` when composing git tags, eliminating an asymmetry that could lead to doubled or missing `v` prefixes when code is copied between SDK release helpers. The final tag format (sdk-python-v0.1.0) is unchanged. Closes #3793 🤖 Generated with [Qwen Code](https://github.com/QwenLM/qwen-code) Co-authored-by: jinye.djy <jinye.djy@alibaba-inc.com>
xaelistic
pushed a commit
to xaelistic/qwen-code
that referenced
this pull request
Jun 7, 2026
…#3832) Align the Python SDK's TAG_PREFIX with the TypeScript SDK convention by changing it from 'sdk-python-' to 'sdk-python-v'. This removes the need for callers to manually inject the `v` when composing git tags, eliminating an asymmetry that could lead to doubled or missing `v` prefixes when code is copied between SDK release helpers. The final tag format (sdk-python-v0.1.0) is unchanged. Closes QwenLM#3793 🤖 Generated with [Qwen Code](https://github.com/QwenLM/qwen-code) Co-authored-by: jinye.djy <jinye.djy@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3793
Reviewer Test Plan
Generated with Qwen Code