Context
PR #3685 introduced TAG_PREFIX = 'sdk-python-' (no trailing v) in packages/sdk-python/scripts/get-release-version.js, while the TS sibling uses 'sdk-typescript-v' (with v included). Callers in the Python file manually inject v when composing tags, while TS callers concatenate ${TAG_PREFIX}${version} directly.
Both produce correct tags today, but the asymmetry is a footgun — a future maintainer copying a code path between files will silently double the v (sdk-python-vv0.1.0) or drop it (sdk-typescript-0.1.0), and per-file tests will not catch a mistake in the other file.
Suggested fix
Standardize on the TS convention: TAG_PREFIX = 'sdk-python-v'. Then drop the v injection at callers so all four tag-composition sites read uniformly ${TAG_PREFIX}${version}.
This should be done as a coordinated change across all three release helper files, and only after all existing sdk-python-v* tags/releases have been verified to not break.
Related
Context
PR #3685 introduced
TAG_PREFIX = 'sdk-python-'(no trailingv) inpackages/sdk-python/scripts/get-release-version.js, while the TS sibling uses'sdk-typescript-v'(withvincluded). Callers in the Python file manually injectvwhen composing tags, while TS callers concatenate${TAG_PREFIX}${version}directly.Both produce correct tags today, but the asymmetry is a footgun — a future maintainer copying a code path between files will silently double the
v(sdk-python-vv0.1.0) or drop it (sdk-typescript-0.1.0), and per-file tests will not catch a mistake in the other file.Suggested fix
Standardize on the TS convention:
TAG_PREFIX = 'sdk-python-v'. Then drop thevinjection at callers so all four tag-composition sites read uniformly${TAG_PREFIX}${version}.This should be done as a coordinated change across all three release helper files, and only after all existing
sdk-python-v*tags/releases have been verified to not break.Related