Merged
Conversation
sfdye
reviewed
Oct 16, 2018
sfdye
reviewed
Oct 16, 2018
Member
|
Thanks for your PR. Very useful addition! Would you mind adding some unit tests for the new methods? |
Paradoxis
reviewed
Oct 17, 2018
Member
|
Also some conflicts need to be resolved 😝 |
sfdye
reviewed
Oct 18, 2018
doc/examples/Repository.rst
Outdated
| .. code-block:: python | ||
|
|
||
| >>> repo = g.get_repo("PyGithub/PyGithub") | ||
| >>> repo.mark_notification_has_read() |
Member
There was a problem hiding this comment.
Suggested change
| >>> repo.mark_notification_has_read() | |
| >>> repo.mark_notification_as_read() |
2f4fb82 to
7ff4ddc
Compare
Contributor
Author
|
@sfdye I think I took into account all your feedbacks now. Please let me know if I forgot something. |
candrikos
pushed a commit
to candrikos/PyGithub
that referenced
this pull request
Sep 25, 2020
Wraps the parts of the notification API that allows the user to mark notifications as read. New methods are : - Notification.mark_as_read : marks a single notification thread as read - Repository.mark_notifications_as_read : marks all the notifications for a given repository as read - AuthenticatedUser.mark_notifications_as_read : marks all the notifications as read Aims to fix : PyGithub#571 and simply uses the APIs described on this page : https://developer.github.com/enterprise/11.10.340/v3/activity/notifications/ A weird thing I noticed doing this is that Repository.notifications_url doesn't seem to be usable directly. I used Repository.url + "/notifications" instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps the parts of the notification API that allows the user to mark notifications as read.
New methods are :
Aims to fix : #571 and simply uses the APIs described on this page : https://developer.github.com/enterprise/11.10.340/v3/activity/notifications/
A weird thing I noticed doing this is that Repository.notifications_url doesn't seem to be usable directly. I used Repository.url + "/notifications" instead.