Add possibility to mark a thread/notification as done#2985
Merged
EnricoMi merged 2 commits intoPyGithub:mainfrom Jul 30, 2024
Merged
Add possibility to mark a thread/notification as done#2985EnricoMi merged 2 commits intoPyGithub:mainfrom
EnricoMi merged 2 commits intoPyGithub:mainfrom
Conversation
A new function `mark_as_done` besides `mark_as_read`.
ce0d4df to
1a4b7cb
Compare
EnricoMi
reviewed
Jul 29, 2024
Collaborator
EnricoMi
left a comment
There was a problem hiding this comment.
Can you add a test for this new method, please?
Contributor
Author
|
@EnricoMi done |
4e0eb1c to
102d971
Compare
102d971 to
cc3531e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to mark a notification as done, following the already implemented
mark_as_readby #932. Duplicated by #2976.Fixes #2947
Co-authored-by: Hodei Navarro hodei.navarro@outlook.com